pdfviewer: remove simple implementation for non-isolated groups. will be implemented in skia most p…

experimental/PdfViewer/SkPdfRenderer.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCanvas.h"
 #include "SkDevice.h"
 #include "SkForceLinking.h"
@@ skipping 632 matching lines @@
 //     CON: multiple drawings (but on smaller areas), pay a price at loading pdf to compute a pdf draw plan
 //          on average, a load with empty draw is 100ms on all the skps we have, for complete sites
 // 3) support them natively in SkCanvas
 //     PRO: simple
 //     CON: we would still need to use a form of readPixels anyway, so perf might be the same as 1)
 // 4) compile a plan using pathops, and render once without any fancy rules with backdrop
 //     PRO: simple, fast
 //     CON: pathops must be bug free first + time to compute new paths
 //          pay a price at loading pdf to compute a pdf draw plan
 //          on average, a load with empty draw is 100ms on all the skps we have, for complete sites
+// 5) for knockout, render the objects in reverse order, and add every object to the clip, and any new draw will be cliped
 
 
 // TODO(edisonn): draw plan from point! - list of draw ops of a point, like a tree!
 // TODO(edisonn): Minimal PDF to draw some points - remove everything that it is not needed, save pdf uncompressed
 
 
 
 static void doGroup_before(PdfContext* pdfContext, SkCanvas* canvas, SkRect bbox, SkPdfTransparencyGroupDictionary* tgroup, bool page) {
     SkRect bboxOrig = bbox;
     SkBitmap backdrop;
     bool isolatedGroup = tgroup->I(pdfContext->fPdfDoc);
 //  bool knockoutGroup = tgroup->K(pdfContext->fPdfDoc);
-    bool hasPixels = false;
-    if (!isolatedGroup) {
-        // TODO(edisonn): if the rect is not mapable, the operation could be expensive, e.g.
-        // a diagonal long but small rect would require to save all the page
-        SkMatrix inverse;
-        if (pdfContext->fGraphicsState.fCTM.mapRect(&bbox) &&
-                canvas->getTotalMatrix().invert(&inverse) &&
-                inverse.mapRect(&bbox)) {
-            SkIRect area = SkIRect::MakeLTRB(SkScalarTruncToInt(bbox.left()),
-                                             SkScalarTruncToInt(bbox.top()),
-                                             SkScalarTruncToInt(bbox.right()) + 2,
-                                             SkScalarTruncToInt(bbox.bottom()) + 2);
-            SkBitmap dummy;
-            if (canvas->readPixels(area, &dummy)) {
-                hasPixels = true;
-            }
-        }
-    }
     SkPaint paint;
     pdfContext->fGraphicsState.applyGraphicsState(&paint, false);
     canvas->saveLayer(&bboxOrig, isolatedGroup ? &paint : NULL);
-
-    if (hasPixels) {
-        canvas->drawBitmapRect(backdrop, bboxOrig, NULL);
-    }
 }
 
+// TODO(edisonn): non isolation implemented in skia
 //static void doGroup_after(PdfContext* pdfContext, SkCanvas* canvas, SkRect bbox, SkPdfTransparencyGroupDictionary* tgroup) {
+//    if not isolated
+//        canvas->drawBitmapRect(backdrop, bboxOrig, NULL);
 //}
 
 static PdfResult doXObject_Form(PdfContext* pdfContext, SkCanvas* canvas, SkPdfType1FormDictionary* skobj) {
     if (!skobj || !skobj->hasStream()) {
         return kIgnoreError_PdfResult;
     }
 
     if (!skobj->has_BBox()) {
         return kIgnoreError_PdfResult;
     }
 
     PdfOp_q(pdfContext, canvas, NULL);
 
-
-
     canvas->save();
 
 
     if (skobj->Resources(pdfContext->fPdfDoc)) {
         pdfContext->fGraphicsState.fResources = skobj->Resources(pdfContext->fPdfDoc);
     }
 
     SkTraceMatrix(pdfContext->fGraphicsState.fCTM, "Current matrix");
 
     if (skobj->has_Matrix()) {
@@ skipping 1745 matching lines @@
 
     rect = SkRect::MakeWH(width, height);
 
     setup_bitmap(output, (int)SkScalarToDouble(width), (int)SkScalarToDouble(height));
 
     SkAutoTUnref<SkDevice> device(SkNEW_ARGS(SkDevice, (*output)));
     SkCanvas canvas(device);
 
     return renderer.renderPage(page, &canvas, rect);
 }