Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: net/test/python_utils.cc

Issue 21537002: Remove hard dependency on bundled python_26 in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@glyphcache_20130604
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/python_utils.cc
diff --git a/net/test/python_utils.cc b/net/test/python_utils.cc
index 30c5f679a8adeed79b2d28d2232f4ad9478ff613..da5a1d31264b18e764b1fbf772e0462d19484022 100644
--- a/net/test/python_utils.cc
+++ b/net/test/python_utils.cc
@@ -108,11 +108,7 @@ bool GetPythonCommand(CommandLine* python_cmd) {
DCHECK(python_cmd);
base::FilePath dir;
#if defined(OS_WIN)
- if (!PathService::Get(base::DIR_SOURCE_ROOT, &dir))
- return false;
- dir = dir.Append(FILE_PATH_LITERAL("third_party"))
- .Append(FILE_PATH_LITERAL("python_26"))
- .Append(FILE_PATH_LITERAL("python.exe"));
+ dir = base::FilePath(FILE_PATH_LITERAL("python.exe"));
Paweł Hajdan Jr. 2013/08/01 17:56:28 nit: Sort of a pre-existing thing, but "dir" is te
Daniel Bratell 2013/08/02 07:27:53 It means that we'll start using python.bat from de
#elif defined(OS_POSIX)
dir = base::FilePath("python");
#endif

Powered by Google App Engine
This is Rietveld 408576698