Remove hard dependency on bundled python_26 in tests

net/test/spawned_test_server/local_test_server_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/spawned_test_server/local_test_server.h"
 
 #include <windows.h>
 #include <wincrypt.h>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/environment.h"
 #include "base/files/file_path.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/thread.h"
 #include "base/win/scoped_handle.h"
@@ skipping 51 matching lines @@
   thread.Stop();
   // If the timeout kicked in, abort.
   if (unblocked) {
     LOG(ERROR) << "Timeout exceeded for ReadData";
     return false;
   }
 
   return true;
 }
 
+// Class that sets up a temporary path that includes the supplied path
+// at the end.
+class ScopedPath {
+  // TODO: By making this more generic we can possibly reused it at

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: TODO should have a username in parentheses. Ideally TODO(bratell), but feel
free to say TODO(phajdan.jr).

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=TODO_C...

+  //       other places such as chrome/common/multi_process_lock_unittest.cc.
+ public:
+  // Constructor which sets up the environment to include the path to
+  // third_party/python_26.

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: Don't mention python_26 here as it's supposed to be generic.

+  ScopedPath(const base::FilePath& path_to_add);

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: One-parameter ctros should be marked explicit.

+
+  // Destructor that restores the path that were active when the
+  // object was constructed.
+  ~ScopedPath();
+
+ private:
+  // The PATH environment variable before it was changed or an empty
+  // string if there was no PATH environment variable.
+  std::string old_path_;
+
+  // The helper object that allows us to read and set environment
+  // variables more easily.
+  scoped_ptr<base::Environment> environment_;
+
+  // A flag saying if we have actually modified the environment. If we
+  // haven't then we should also not try to "restore" it in the

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: No need for the "If we haven't" part (up to you though - feel free to keep
if you think it should be there).

+  // destructor.
+  bool path_modified_;
+
+  // This is a local stack based helper object. Copying it would make

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: DISALLOW_COPY_AND_ASSIGN is a common enough macro that it doesn't need a
comment.

+  // no sense and would cause bugs.
+  DISALLOW_COPY_AND_ASSIGN(ScopedPath);
+};
+
+ScopedPath::ScopedPath(const base::FilePath& path_to_add)
+    : environment_(base::Environment::Create()),
+      path_modified_(false) {
+  // Retrieves the old PATH, adds the new path to the end of it and

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: No need for this comment.

+  // then restores the original PATH in the destructor.
+  environment_->GetVar("PATH", &old_path_);
+
+  std::string new_value = old_path_;
+  if (!new_value.empty())
+    new_value += ";";
+
+  new_value += WideToUTF8(path_to_add.value());
+
+  path_modified_ = environment_->SetVar("PATH", new_value);
+}
+
+ScopedPath::~ScopedPath() {
+  if (path_modified_) {

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: I prefer an early return, like:

if (!path_modified_)
  return;

if (old_path_.empty())
  ...

+    if (old_path_.empty())
+      environment_->UnSetVar("PATH");
+    else
+      environment_->SetVar("PATH", old_path_);
+  }
+}
+
 }  // namespace
 
 namespace net {
 
+

[Paweł Hajdan Jr., 2013/08/26 21:39:49]

nit: No need for this empty line.

 bool LocalTestServer::LaunchPython(const base::FilePath& testserver_path) {
   CommandLine python_command(CommandLine::NO_PROGRAM);
   if (!GetPythonCommand(&python_command))
     return false;
 
   python_command.AppendArgPath(testserver_path);
   if (!AddCommandLineArguments(&python_command))
     return false;
 
   HANDLE child_read = NULL;
@@ skipping 29 matching lines @@
   if (!job_handle_.IsValid()) {
     LOG(ERROR) << "Could not create JobObject.";
     return false;
   }
 
   if (!base::SetJobObjectAsKillOnJobClose(job_handle_.Get())) {
     LOG(ERROR) << "Could not SetInformationJobObject.";
     return false;
   }
 
+  // Add our internal python to the path so it can be used if there is
+  // no system python.
+  base::FilePath python_dir;
+  if (!PathService::Get(base::DIR_SOURCE_ROOT, &python_dir)) {
+    LOG(ERROR) << "Could not locate source root directory.";
+    return false;
+  }
+  python_dir = python_dir.AppendASCII("third_party").AppendASCII("python_26");
+  ScopedPath python_path(python_dir);
   base::LaunchOptions launch_options;
   launch_options.inherit_handles = true;
   launch_options.job_handle = job_handle_.Get();
   if (!base::LaunchProcess(python_command, launch_options, &process_handle_)) {
     LOG(ERROR) << "Failed to launch " << python_command.GetCommandLineString();
     return false;
   }
 
   return true;
 }
@@ skipping 19 matching lines @@
   if (!ParseServerData(server_data)) {
     LOG(ERROR) << "Could not parse server_data: " << server_data;
     return false;
   }
 
   return true;
 }
 
 }  // namespace net