Fix ValueSet.addValuesFromDicts

Fix ValueSet.addValuesFromDicts

Currently, addValuesFromDicts() calls addValue(), which adds summary values for
Numerics to the ValueSet and to the Numeric's diagnostics...  but those summary
values should already exist in the valueDicts, in the Numeric's diagnostics at
least, even if the summary values were stripped out for some reason.

This CL makes addValuesFromDicts bypass adding the summary ScalarNumeric values.

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7de849b81d47d98f57b2418c7532b9dbb4656f40

[benjhayden, 2016-07-15 22:46:14]

Description was changed from

==========
Fix ValueSet.addValuesFromDicts

Currently, addValuesFromDicts() calls addValue(), which adds summary values for
Numerics to the ValueSet and to the Numeric's diagnostics...  but those summary
values should already exist in the valueDicts, in the Numeric's diagnostics at
least, even if the summary values were stripped out for some reason.
==========

to

==========
Fix ValueSet.addValuesFromDicts

Currently, addValuesFromDicts() calls addValue(), which adds summary values for
Numerics to the ValueSet and to the Numeric's diagnostics...  but those summary
values should already exist in the valueDicts, in the Numeric's diagnostics at
least, even if the summary values were stripped out for some reason.

This CL makes addValuesFromDicts bypass adding the summary ScalarNumeric values.
==========

[benjhayden, 2016-07-15 22:46:43]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, robertocn@chromium.org

[benjhayden, 2016-07-15 22:46:44]

PTAL :-)

[RobertoCN, 2016-07-15 22:54:53]

Applied the patch on top of my tests and makes it pass, so LGTM

[benjhayden, 2016-07-15 23:03:51]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-07-15 23:04:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eakuefner, 2016-07-15 23:04:17]

lgtm

[commit-bot: I haz the power, 2016-07-15 23:29:18]

Description was changed from

==========
Fix ValueSet.addValuesFromDicts

Currently, addValuesFromDicts() calls addValue(), which adds summary values for
Numerics to the ValueSet and to the Numeric's diagnostics...  but those summary
values should already exist in the valueDicts, in the Numeric's diagnostics at
least, even if the summary values were stripped out for some reason.

This CL makes addValuesFromDicts bypass adding the summary ScalarNumeric values.
==========

to

==========
Fix ValueSet.addValuesFromDicts

Currently, addValuesFromDicts() calls addValue(), which adds summary values for
Numerics to the ValueSet and to the Numeric's diagnostics...  but those summary
values should already exist in the valueDicts, in the Numeric's diagnostics at
least, even if the summary values were stripped out for some reason.

This CL makes addValuesFromDicts bypass adding the summary ScalarNumeric values.

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-15 23:29:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...