Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2153673002: Remove some dead code related to SSLStatus in the renderer (Closed)

Created:
4 years, 5 months ago by jam
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez, Nate Chapin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead code related to SSLStatus in the renderer BUG=598073 Committed: https://crrev.com/3b059c57b8eebad43e1f2f04f76e39719f383866 Cr-Commit-Position: refs/heads/master@{#406094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M content/common/frame_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/context_menu_params.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/context_menu_params_builder.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebContextMenuData.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
jam
4 years, 5 months ago (2016-07-18 18:12:50 UTC) #6
Nate Chapin
lgtm l
4 years, 5 months ago (2016-07-18 18:15:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153673002/1
4 years, 5 months ago (2016-07-18 18:16:02 UTC) #9
jam
+Tom for content/common/frame_messages.h
4 years, 5 months ago (2016-07-18 18:23:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/219817)
4 years, 5 months ago (2016-07-18 18:28:40 UTC) #14
Tom Sepez
LGTM on deleting member from message.
4 years, 5 months ago (2016-07-18 18:31:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153673002/1
4 years, 5 months ago (2016-07-18 19:14:46 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/222721)
4 years, 5 months ago (2016-07-18 20:34:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153673002/1
4 years, 5 months ago (2016-07-18 20:36:24 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 21:10:36 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:10:49 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:12:23 UTC) #26
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3b059c57b8eebad43e1f2f04f76e39719f383866
Cr-Commit-Position: refs/heads/master@{#406094}

Powered by Google App Engine
This is Rietveld 408576698