Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2153633002: Add PLATFORM_EXPORT to Layout{Point,Size} classes. (Closed)

Created:
4 years, 5 months ago by wkorman
Modified:
4 years, 5 months ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PLATFORM_EXPORT to Layout{Point,Size} classes. During debugging use of toString() is often helpful. PLATFORM_EXPORT is required for the method implementations to be available to some callsites at link time. Similar classes in this package already have PLATFORM_EXPORT on the class declaration. TBR=pdr Committed: https://crrev.com/3561d11a66334b78922e86c8913e82d4afae6071 Cr-Commit-Position: refs/heads/master@{#405667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/geometry/LayoutPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutSize.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
wkorman
4 years, 5 months ago (2016-07-15 01:20:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153633002/1
4 years, 5 months ago (2016-07-15 01:21:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 01:27:32 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 01:27:44 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 01:30:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3561d11a66334b78922e86c8913e82d4afae6071
Cr-Commit-Position: refs/heads/master@{#405667}

Powered by Google App Engine
This is Rietveld 408576698