google_apis/gcm/engine/gcm_store_impl.h - Issue 215363007: [GCM] Adding basic G-services handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/gcm_store_impl.h

Issue 215363007: [GCM] Adding basic G-services handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding unit tests and addressing CR feedback Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/gcm_store_impl.h

diff --git a/google_apis/gcm/engine/gcm_store_impl.h b/google_apis/gcm/engine/gcm_store_impl.h

index 971367a8bf01960fad72894a6f4dc453a99f0c0c..c7886dd1b4120df6de82db03b3415a17803e4efb 100644

--- a/google_apis/gcm/engine/gcm_store_impl.h

+++ b/google_apis/gcm/engine/gcm_store_impl.h

@@ -74,6 +74,13 @@ class GCM_EXPORT GCMStoreImpl : public GCMStore {

virtual void RemoveOutgoingMessages(const PersistentIdList& persistent_ids,

const UpdateCallback& callback) OVERRIDE;

+ // GService Settings handling.

+ virtual void UpdateGServicesSettings(

+ const std::vector<std::string>& settings_to_remove,

+ const std::map<std::string, std::string>& settings_to_add,

+ const base::Time& last_checkin_time,

+ const UpdateCallback& callback) OVERRIDE;

private:

typedef std::map<std::string, int> AppIdToMessageCountMap;