[GCM] Adding basic G-services handling

google_apis/gcm/engine/checkin_request.cc

Index: google_apis/gcm/engine/checkin_request.cc
diff --git a/google_apis/gcm/engine/checkin_request.cc b/google_apis/gcm/engine/checkin_request.cc
index 94a6fc9e38ac8d8d27f9a7cdd0c69f5cd413695b..dbd9d13684804514fd90b63e78d840f8be13b099 100644
--- a/google_apis/gcm/engine/checkin_request.cc
+++ b/google_apis/gcm/engine/checkin_request.cc
@@ -141,7 +141,7 @@ void CheckinRequest::OnURLFetchComplete(const net::URLFetcher* source) {
                << response_status << ". Checkin failed.";
     RecordCheckinStatusToUMA(response_status == net::HTTP_BAD_REQUEST ?
         HTTP_BAD_REQUEST : HTTP_UNAUTHORIZED);
-    callback_.Run(0,0);
+    callback_.Run(response_proto);

[fgorski, 2014/03/28 14:30:51]

could we set android_id and security_token to 0 before that?

[Nicolas Zea, 2014/03/28 18:31:38]

You could pass an empty protobuf here I suspect.

[fgorski, 2014/03/29 01:09:32]

I know I just don't like that idea that much. All of the checks for
has_android_id and so on...

     return;
   }
 
@@ -167,7 +167,7 @@ void CheckinRequest::OnURLFetchComplete(const net::URLFetcher* source) {
   }
 
   RecordCheckinStatusToUMA(SUCCESS);
-  callback_.Run(response_proto.android_id(), response_proto.security_token());
+  callback_.Run(response_proto);
 }
 
 }  // namespace gcm