Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 215363006: Revert 259561 "Set the default ASan options for executables buil..." (Closed)

Created:
6 years, 9 months ago by Jun Mukai
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 259561 "Set the default ASan options for executables buil..." > Set the default ASan options for executables built with ASan on Linux. > > This is a copy of https://codereview.chromium.org/25687005/ updated for the current trunk > with the link_dependency attribute speculatively added to base/base.gyp:sanitizer_options > to avoid potential dependency cycles. > > This CL introduces a module, base/debug/sanitizer_options.cc, which will override > the defaults for various dynamic tools (only ASan at this moment). For every executable > built with a dynamic tool this module will be linked into that executable, providing > weak functions to be called by the tool. > > The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc > has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1 > will have the same options as google-chrome-asan. > The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc > has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc. > > GYP changes for OSX and iOS will be committed separately. > > BUG=302040 > TBR=thakis@chromium.org > > Review URL: https://codereview.chromium.org/201153007 TBR=glider@chromium.org BUG=357093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -88 lines) Patch
M trunk/src/base/base.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/base/debug/sanitizer_options.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M trunk/src/build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/app/chrome_exe_main_gtk.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M trunk/src/components/nacl.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jun Mukai
6 years, 9 months ago (2014-03-28 00:09:28 UTC) #1
Jun Mukai
6 years, 9 months ago (2014-03-28 00:09:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r260037.

Powered by Google App Engine
This is Rietveld 408576698