Support for multiple register values

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 761 matching lines @@
   M(UnboxFloat64x2)                                                            \
   M(BinaryFloat64x2Op)                                                         \
   M(Float64x2Zero)                                                             \
   M(Float64x2Constructor)                                                      \
   M(Float64x2Splat)                                                            \
   M(Float32x4ToFloat64x2)                                                      \
   M(Float64x2ToFloat32x4)                                                      \
   M(Simd64x2Shuffle)                                                           \
   M(Float64x2ZeroArg)                                                          \
   M(Float64x2OneArg)                                                           \
+  M(MergedMath2)                                                               \
+  M(ExtractNthOutput)                                                          \
 
 
 #define FORWARD_DECLARATION(type) class type##Instr;
 FOR_EACH_INSTRUCTION(FORWARD_DECLARATION)
 #undef FORWARD_DECLARATION
 
 
 // Functions required in all concrete instruction classes.
 #define DECLARE_INSTRUCTION(type)                                              \
   virtual Tag tag() const { return k##type; }                                  \
@@ skipping 300 matching lines @@
   friend class CheckSmiInstr;
   friend class CheckArrayBoundInstr;
   friend class CheckEitherNonSmiInstr;
   friend class LICM;
   friend class DoubleToSmiInstr;
   friend class DoubleToDoubleInstr;
   friend class DoubleToFloatInstr;
   friend class FloatToDoubleInstr;
   friend class InvokeMathCFunctionInstr;
   friend class MergedMathInstr;
+  friend class MergedMath2Instr;
   friend class FlowGraphOptimizer;
   friend class LoadIndexedInstr;
   friend class StoreIndexedInstr;
   friend class StoreInstanceFieldInstr;
   friend class ComparisonInstr;
   friend class TargetEntryInstr;
   friend class JoinEntryInstr;
   friend class InstanceOfInstr;
   friend class PolymorphicInstanceCallInstr;
   friend class SmiToDoubleInstr;
@@ skipping 646 matching lines @@
 
   intptr_t ssa_temp_index() const { return ssa_temp_index_; }
   void set_ssa_temp_index(intptr_t index) {
     ASSERT(index >= 0);
     ASSERT(is_used());
     ssa_temp_index_ = index;
   }
   bool HasSSATemp() const { return ssa_temp_index_ >= 0; }
   void ClearSSATempIndex() { ssa_temp_index_ = -1; }
 
+
+  virtual bool RequiresTwoSSATempIndexes() const {
+    return false;
+  }
+
+  intptr_t ssa_temp_index2() const { return ssa_temp_index2_; }
+  void set_ssa_temp_index2(intptr_t index) {
+    ASSERT(index >= 0);
+    ASSERT(is_used());
+    ASSERT(RequiresTwoSSATempIndexes());
+    ssa_temp_index2_ = index;
+  }
+  void ClearSSATempIndex2() { ssa_temp_index2_ = -1; }
+
+
   bool is_used() const { return (use_kind_ != kEffect); }
   void set_use_kind(UseKind kind) { use_kind_ = kind; }
 
   // Compile time type of the definition, which may be requested before type
   // propagation during graph building.
   CompileType* Type() {
     if (type_ == NULL) {
       type_ = ComputeInitialType();
     }
     return type_;
@@ skipping 103 matching lines @@
  protected:
   friend class RangeAnalysis;
   friend class Value;
 
   Range* range_;
   CompileType* type_;
 
  private:
   intptr_t temp_index_;
   intptr_t ssa_temp_index_;
+  intptr_t ssa_temp_index2_;

[Vyacheslav Egorov (Google), 2014/04/03 18:10:09]

Can we sink it down into instructions that actually use it, making setters and
getters virtual?

[Cutch, 2014/04/03 18:35:07]

Done.

   Value* input_use_list_;
   Value* env_use_list_;
   UseKind use_kind_;
 
   Object& constant_value_;
 
   DISALLOW_COPY_AND_ASSIGN(Definition);
 };
 
 
@@ skipping 5378 matching lines @@
   }
 
   ZoneGrowableArray<Value*>* inputs_;
 
   const MethodRecognizer::Kind recognized_kind_;
 
   DISALLOW_COPY_AND_ASSIGN(InvokeMathCFunctionInstr);
 };
 
 
+class ExtractNthOutputInstr : public TemplateDefinition<1> {
+ public:
+  // Extract the Nth output register from value.
+  ExtractNthOutputInstr(Value* value, intptr_t n, Representation rep)
+      : index_(n),
+        rep_(rep) {
+    SetInputAt(0, value);
+  }
+
+  Value* value() const { return inputs_[0]; }
+
+  DECLARE_INSTRUCTION(ExtractNthOutput)
+
+  virtual CompileType ComputeType() const;
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+  virtual bool CanDeoptimize() const { return false; }
+
+  intptr_t index() const { return index_; }
+
+  virtual Representation representation() const {
+    return rep_;
+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT(idx == 0);
+    if (representation() == kTagged) {
+      return kPairOfTagged;
+    } else if (representation() == kUnboxedDouble) {
+      return kPairOfUnboxedDouble;
+    }
+    UNREACHABLE();
+    return rep_;
+  }
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    ExtractNthOutputInstr* other_extract = other->AsExtractNthOutput();
+    return (other_extract->representation() == representation()) &&
+           (other_extract->index() == index());
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+ private:
+  const intptr_t index_;
+  const Representation rep_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtractNthOutputInstr);
+};
+
+
+class MergedMath2Instr : public Definition {
+ public:
+  enum Kind {
+    kTruncDivMod,
+    kSinCos,
+  };
+
+  MergedMath2Instr(ZoneGrowableArray<Value*>* inputs,
+                   intptr_t original_deopt_id,
+                   MergedMath2Instr::Kind kind);
+
+  static intptr_t InputCountFor(MergedMath2Instr::Kind kind) {
+    if (kind == kTruncDivMod) {
+      return 2;
+    } else if (kind == kSinCos) {
+      return 1;
+    } else {
+      UNIMPLEMENTED();
+      return -1;
+    }
+  }
+
+  virtual bool RequiresTwoSSATempIndexes() const {
+    return true;
+  }
+
+  MergedMath2Instr::Kind kind() const { return kind_; }
+
+  virtual intptr_t InputCount() const { return inputs_->length(); }
+
+  virtual Value* InputAt(intptr_t i) const {
+    return (*inputs_)[i];
+  }
+
+  static intptr_t OutputIndexOf(intptr_t kind);
+  static intptr_t OutputIndexOf(Token::Kind token);
+
+  virtual CompileType ComputeType() const;
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+
+  virtual bool CanDeoptimize() const {
+    if (kind_ == kTruncDivMod) {
+      return true;
+    } else if (kind_ == kSinCos) {
+      return false;
+    } else {
+      UNIMPLEMENTED();
+      return false;
+    }
+  }
+
+  virtual Representation representation() const {
+    if (kind_ == kTruncDivMod) {
+      return kPairOfTagged;
+    } else if (kind_ == kSinCos) {
+      return kPairOfUnboxedDouble;
+    } else {
+      UNIMPLEMENTED();
+      return kTagged;
+    }
+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT((0 <= idx) && (idx < InputCount()));
+    if (kind_ == kTruncDivMod) {
+      return kTagged;
+    } else if (kind_ == kSinCos) {
+      return kUnboxedDouble;
+    } else {
+      UNIMPLEMENTED();
+      return kTagged;
+    }
+  }
+
+  virtual intptr_t DeoptimizationTarget() const { return deopt_id_; }
+
+  DECLARE_INSTRUCTION(MergedMath2)
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    MergedMath2Instr* other_invoke = other->AsMergedMath2();
+    return other_invoke->kind() == kind();
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+  static const char* KindToCString(MergedMath2Instr::Kind kind) {
+    if (kind == kTruncDivMod) return "TruncDivMod";
+    if (kind == kSinCos) return "SinCos";
+    UNIMPLEMENTED();
+    return "";
+  }
+
+ private:
+  virtual void RawSetInputAt(intptr_t i, Value* value) {
+    (*inputs_)[i] = value;
+  }
+
+  ZoneGrowableArray<Value*>* inputs_;
+  MergedMath2Instr::Kind kind_;
+  DISALLOW_COPY_AND_ASSIGN(MergedMath2Instr);
+};
+
+
 class MergedMathInstr : public Definition {
  public:
   enum Kind {
     kTruncDivMod,
     kTruncDivRem,
     kSinCos,
   };
 
   MergedMathInstr(ZoneGrowableArray<Value*>* inputs,
                   intptr_t original_deopt_id,
@@ skipping 424 matching lines @@
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_