Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 215363003: Make the screenshare notification window 85% opaque. (Closed)

Created:
6 years, 9 months ago by jiayl
Modified:
6 years, 8 months ago
Reviewers:
Robert Sesek, msw
CC:
chromium-reviews, tfarina, Sergey Ulanov, juberti2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make the screenshare notification window 85% opaque. This is to avoid users using the window for hiding sensitive contents that they don't want to share. See https://code.google.com/p/webrtc/issues/detail?id=2789#c36 BUG=https://code.google.com/p/webrtc/issues/detail?id=2789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260224

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
jiayl
msw: ui/views rsesek: ui/cocoa PTAL. Thanks!
6 years, 9 months ago (2014-03-27 21:46:25 UTC) #1
msw
c/b/ui/views lgtm
6 years, 9 months ago (2014-03-28 00:09:05 UTC) #2
Wez
nit: CL description should probably read "slightly transparent"; you're actually making it 85% opaque, not ...
6 years, 9 months ago (2014-03-28 00:19:43 UTC) #3
jiayl
On 2014/03/28 00:19:43, Wez wrote: > nit: CL description should probably read "slightly transparent"; you're ...
6 years, 9 months ago (2014-03-28 00:23:25 UTC) #4
Robert Sesek
lgtm
6 years, 9 months ago (2014-03-28 14:53:46 UTC) #5
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 15:36:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/215363003/1
6 years, 9 months ago (2014-03-28 15:38:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 16:10:11 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290347
6 years, 9 months ago (2014-03-28 16:10:11 UTC) #9
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 16:17:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/215363003/20001
6 years, 9 months ago (2014-03-28 16:20:40 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 19:07:40 UTC) #12
Message was sent while issue was closed.
Change committed as 260224

Powered by Google App Engine
This is Rietveld 408576698