Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2153613003: Revert of Added policy device id validation similar to the existing DM token validation. (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added policy device id validation similar to the existing DM token validation. (patchset #2 id:20001 of https://codereview.chromium.org/2150603002/ ) Reason for revert: Crashes in PFQ information builders in login_OwnershipNotRetaken VM/HWtests. [31587:31603:0715/084815:ERROR:cloud_policy_validator.cc(472)] Empty device id encountered - expected: crbug.com/628720 Original issue's description: > Added policy device id validation similar to the existing DM token validation. > BUG=360708 > > Committed: https://crrev.com/ed0d60b78f377e9279c1ceb3d374ef958fa9903a > Cr-Commit-Position: refs/heads/master@{#405719} TBR=atwilson@chromium.org,ljusten@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=360708 Committed: https://crrev.com/c3a05273de3644bb158b2ffaf44ad89e7958fe44 Cr-Commit-Position: refs/heads/master@{#405832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/policy/core/browser/cloud/message_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.h View 5 chunks +0 lines, -9 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M components/policy_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
michaelpg
Created Revert of Added policy device id validation similar to the existing DM token validation.
4 years, 5 months ago (2016-07-15 19:54:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153613003/1
4 years, 5 months ago (2016-07-15 19:55:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 19:56:03 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:59:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3a05273de3644bb158b2ffaf44ad89e7958fe44
Cr-Commit-Position: refs/heads/master@{#405832}

Powered by Google App Engine
This is Rietveld 408576698