Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2153533002: Fix under-invalidation of frame scrollbar on hover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 368
369 // Since the compositor can resize the viewport due to top controls and 369 // Since the compositor can resize the viewport due to top controls and
370 // commit scroll offsets before a WebView::resize occurs, we need to adjust 370 // commit scroll offsets before a WebView::resize occurs, we need to adjust
371 // our scroll extents to prevent clamping the scroll offsets. 371 // our scroll extents to prevent clamping the scroll offsets.
372 void setTopControlsViewportAdjustment(float); 372 void setTopControlsViewportAdjustment(float);
373 IntSize topControlsSize() const { return IntSize(0, ceilf(m_topControlsViewp ortAdjustment)); } 373 IntSize topControlsSize() const { return IntSize(0, ceilf(m_topControlsViewp ortAdjustment)); }
374 374
375 IntPoint maximumScrollPosition() const override; 375 IntPoint maximumScrollPosition() const override;
376 376
377 // ScrollableArea interface 377 // ScrollableArea interface
378 void scrollControlWasSetNeedsPaintInvalidation() override { }
379 void getTickmarks(Vector<IntRect>&) const override; 378 void getTickmarks(Vector<IntRect>&) const override;
380 IntRect scrollableAreaBoundingBox() const override; 379 IntRect scrollableAreaBoundingBox() const override;
381 bool scrollAnimatorEnabled() const override; 380 bool scrollAnimatorEnabled() const override;
382 bool usesCompositedScrolling() const override; 381 bool usesCompositedScrolling() const override;
383 bool shouldScrollOnMainThread() const override; 382 bool shouldScrollOnMainThread() const override;
384 GraphicsLayer* layerForScrolling() const override; 383 GraphicsLayer* layerForScrolling() const override;
385 GraphicsLayer* layerForHorizontalScrollbar() const override; 384 GraphicsLayer* layerForHorizontalScrollbar() const override;
386 GraphicsLayer* layerForVerticalScrollbar() const override; 385 GraphicsLayer* layerForVerticalScrollbar() const override;
387 GraphicsLayer* layerForScrollCorner() const override; 386 GraphicsLayer* layerForScrollCorner() const override;
388 int scrollSize(ScrollbarOrientation) const override; 387 int scrollSize(ScrollbarOrientation) const override;
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
947 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 946 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
948 setIsVisuallyNonEmpty(); 947 setIsVisuallyNonEmpty();
949 } 948 }
950 949
951 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 950 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
952 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView()); 951 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView());
953 952
954 } // namespace blink 953 } // namespace blink
955 954
956 #endif // FrameView_h 955 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698