Issue 215353002: views: Simplify SimpleMessageBoxViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215353002: views: Simplify SimpleMessageBoxViews. (Closed)

Created:
6 years, 9 months ago by sadrul

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Simplify SimpleMessageBoxViews. Have the SimplyMessageBoxViews record the user response in a MessageBoxResult it doesn't own, so that the user-response is available even after the dialog has been destroyed. This simplifies the lifetime of the message-box a bit. BUG=355083 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260061

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -28 lines)			Patch
	M	chrome/browser/ui/views/simple_message_box_views.cc	View	1	11 chunks	+22 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

Nice! LGTM https://codereview.chromium.org/215353002/diff/1/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/215353002/diff/1/chrome/browser/ui/views/simple_message_box_views.cc#newcode9 chrome/browser/ui/views/simple_message_box_views.cc:9: #include "base/memory/ref_counted.h" I think you can remove ...

6 years, 9 months ago (2014-03-27 23:24:47 UTC) #2

sadrul

https://codereview.chromium.org/215353002/diff/1/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/215353002/diff/1/chrome/browser/ui/views/simple_message_box_views.cc#newcode9 chrome/browser/ui/views/simple_message_box_views.cc:9: #include "base/memory/ref_counted.h" On 2014/03/27 23:24:47, sky wrote: > I ...

6 years, 9 months ago (2014-03-28 02:09:19 UTC) #3

sadrul

6 years, 9 months ago (2014-03-28 02:11:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r260061 (presubmit successful).

Expand Messages | Collapse Messages