Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: telemetry/telemetry/page/page_run_end_to_end_unittest.py

Issue 2153513002: [Telemetry] Ensure that story display names are unique (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: fix typo Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/story_runner_unittest.py ('k') | telemetry/telemetry/story/story.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/page_run_end_to_end_unittest.py
diff --git a/telemetry/telemetry/page/page_run_end_to_end_unittest.py b/telemetry/telemetry/page/page_run_end_to_end_unittest.py
index 7932f3357c5629f0b4904fd8959bd3273c9f3432..dcb354aac6853a35b1239ddb7f211bbef4a3bb5f 100644
--- a/telemetry/telemetry/page/page_run_end_to_end_unittest.py
+++ b/telemetry/telemetry/page/page_run_end_to_end_unittest.py
@@ -145,11 +145,14 @@ class ActualPageRunEndToEndTests(unittest.TestCase):
self.CaptureFormattedException()
story_set = story.StorySet()
story_set.AddStory(page_module.Page(
- 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir(),
+ name='foo'))
story_set.AddStory(page_module.Page(
- 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir(),
+ name='bar'))
story_set.AddStory(page_module.Page(
- 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir(),
+ name='baz'))
class Test(legacy_page_test.LegacyPageTest):
@@ -185,9 +188,11 @@ class ActualPageRunEndToEndTests(unittest.TestCase):
self.CaptureFormattedException()
story_set = story.StorySet()
story_set.AddStory(page_module.Page(
- 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir(),
+ name='foo'))
story_set.AddStory(page_module.Page(
- 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', story_set, base_dir=util.GetUnittestDataDir(),
+ name='bar'))
class Test(legacy_page_test.LegacyPageTest):
@@ -571,10 +576,10 @@ class ActualPageRunEndToEndTests(unittest.TestCase):
raise exceptions.AppCrashException
story_set = story.StorySet()
- for _ in range(5):
+ for i in range(5):
story_set.AddStory(
TestPage('file://blank.html', story_set,
- base_dir=util.GetUnittestDataDir()))
+ base_dir=util.GetUnittestDataDir(), name='foo%d' % i))
options = options_for_unittests.GetCopy()
options.output_formats = ['none']
options.suppress_gtest_report = True
« no previous file with comments | « telemetry/telemetry/internal/story_runner_unittest.py ('k') | telemetry/telemetry/story/story.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698