Add config for Linux layout test try bot with --enable-slimming-paint-v2.

Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865.

There are also src-side changes in http://crrev.com/2156633003, now committed.

Bug for master restart: http://crbug.com/631511

BUG=622865
Committed: https://chromium.googlesource.com/chromium/tools/build/+/761a85597e4e990fbf964f5688cf444481eca846

[qyearsley, 2016-07-15 22:23:27]

Description was changed from

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865;
in addition to this, there should be changes in src/tools/mb/mb_config.pyl.

BUG=622865
==========

to

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865;
there are also src-side changes in http://crrev.com/2156633003.

BUG=622865
==========

[qyearsley, 2016-07-15 22:23:27]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-07-15 22:28:18]

qyearsley@chromium.org changed reviewers:
+ pdr@chromium.org

[qyearsley, 2016-07-15 22:28:18]

Note: it seems like it would be useful and ideal if we could add layout test try
bots that can run with arbitrary additional args based on properties.

We may want to commit this first as is, but later (next week) I want to start
preparing to add try bots for running layout tests on all platforms; potentially
when that is done, maybe I could try to make it so that extra arguments to
run-webkit-tests can be specified through properties -- then this separate bot
would be unnecessary.

[Dirk Pranke, 2016-07-15 22:33:02]

dpranke@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Dirk Pranke, 2016-07-15 22:33:03]

I don't think this works, because the chromium_trybot.py recipe needs to find a
"matching waterfall builder", and there isn't one.

I'm not sure what the best way to set up a trybot that doesn't have a matching
waterfall bot but otherwise runs the chromium_trybot recipe is.

Paweł, can you advise?

I'm happy to talk about how to make the layout tests work on any trybot ...

[qyearsley, 2016-07-15 23:08:15]

On 2016/07/15 at 22:33:03, dpranke wrote:
> I don't think this works, because the chromium_trybot.py recipe needs to find
a "matching waterfall builder", and there isn't one.
> 
> I'm not sure what the best way to set up a trybot that doesn't have a matching
waterfall bot but otherwise runs the chromium_trybot recipe is.
> 
> Paweł, can you advise?
> 
> I'm happy to talk about how to make the layout tests work on any trybot ...

Also, it seems like the config for the chromium_tests recipe module for most try
bots is in recipe_modules/chromium_tests/trybots.py, and that requires having a
corresponding continuous builder.

What if BlinkTest (at
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...)
were changed so that it added extra args based on a property in api.properties;
then any builder that uses BlinkTest could specify extra args to add when
running a try job.

Then, hypothetically, we could trigger a try job for the
"--enable-slimming-paint-v2" case with:

  git cl try
--property=webkit_tests_extra_args=--additional-driver-flag=--enable-slimming-paint-v2
--master=tryserver.blink --bot=linux_blink_rel

Then adding this bot would be unnecessary. Does that sound like it would work?

[qyearsley, 2016-07-19 22:34:50]

On 2016/07/15 at 23:08:15, qyearsley wrote:
> On 2016/07/15 at 22:33:03, dpranke wrote:
> > I don't think this works, because the chromium_trybot.py recipe needs to
find a "matching waterfall builder", and there isn't one.
> > 
> > I'm not sure what the best way to set up a trybot that doesn't have a
matching waterfall bot but otherwise runs the chromium_trybot recipe is.
> > 
> > Paweł, can you advise?
> > 
> > I'm happy to talk about how to make the layout tests work on any trybot ...
> 
> Also, it seems like the config for the chromium_tests recipe module for most
try bots is in recipe_modules/chromium_tests/trybots.py, and that requires
having a corresponding continuous builder.
> 
> What if BlinkTest (at
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...)
were changed so that it added extra args based on a property in api.properties;
then any builder that uses BlinkTest could specify extra args to add when
running a try job.
> 
> Then, hypothetically, we could trigger a try job for the
"--enable-slimming-paint-v2" case with:
> 
>   git cl try
--property=webkit_tests_extra_args=--additional-driver-flag=--enable-slimming-paint-v2
--master=tryserver.blink --bot=linux_blink_rel
> 
> Then adding this bot would be unnecessary. Does that sound like it would work?

Uploaded http://crrev.com/2163533003 with this proposal.

[Paweł Hajdan Jr., 2016-07-20 15:20:00]

In general this looks good.

Could you however configure a fake FYI builder in recipes, and make the trybot
mirror it?

I don't think this patch would pass CQ as-is.

[qyearsley, 2016-07-20 16:21:05]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 16:21:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:31:03]

Dry run: Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[qyearsley, 2016-07-20 20:57:57]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 20:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:06:03]

Dry run: Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[qyearsley, 2016-07-20 22:03:16]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 22:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:10:35]

Dry run: Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[qyearsley, 2016-07-20 22:31:29]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 22:31:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:40:04]

Dry run: Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[qyearsley, 2016-07-20 23:19:05]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:24:11]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-20 23:33:39]

Thanks for taking a look Pawel; now added a dummy builder to chromium.fyi config
in recipe_modules/chromium_tests/chromium_fyi.py and moved config for this
builder to recipe_modules/chromium_tests/trybots.py (and fixed builder name in
master.cfg) -- could you have another look?

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/slaves.cfg (right):

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/slaves.cfg:184: 'pool':
'linux_optional1',
Note: I'm not sure what effect this field has - does this value seem OK?

[Paweł Hajdan Jr., 2016-07-22 13:36:12]

I'm fine with other owners finishing this review as I'm taking vacation next
week.

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:281: 'factory':
baseFactory('chromium_trybot'),
Please use m_remote_run instead of baseFactory.

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/slaves.cfg (right):

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/slaves.cfg:184: 'pool':
'linux_optional1',
On 2016/07/20 at 23:33:39, qyearsley wrote:
> Note: I'm not sure what effect this field has - does this value seem OK?

Looks like this is a new pool with just one slave, right? In that case make the
pool name match the builder, i.e. 'linux_layout_tests_slimming_paint_v2'. See
example above.

https://codereview.chromium.org/2153503006/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/trybots.py (left):

https://codereview.chromium.org/2153503006/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/trybots.py:343:
'linux_site_isolation': simple_bot({
Did you intend to remove linux_site_isolation? I don't see corresponding master
change so it seems this'd break it.

[qyearsley, 2016-07-22 16:42:07]

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:281: 'factory':
baseFactory('chromium_trybot'),
On 2016/07/22 at 13:36:12, Paweł Hajdan (OOO back Aug 1) wrote:
> Please use m_remote_run instead of baseFactory.

Done.

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/slaves.cfg (right):

https://codereview.chromium.org/2153503006/diff/80001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/slaves.cfg:184: 'pool':
'linux_optional1',
On 2016/07/22 at 13:36:12, Paweł Hajdan (OOO back Aug 1) wrote:
> On 2016/07/20 at 23:33:39, qyearsley wrote:
> > Note: I'm not sure what effect this field has - does this value seem OK?
> 
> Looks like this is a new pool with just one slave, right? In that case make
the pool name match the builder, i.e. 'linux_layout_tests_slimming_paint_v2'.
See example above.

There are some builders added above that have the pool set to "linux_optional1".

According to the comment on line 35: "slave pools have two competing restraints:
[load and disk space]. Currently we need two optional pools due to disk space."

It appears that an alternative way to add this builder would be to add
slave775-c4 to the list of slaves for "optional_slaves1", and add
"linux_layout_tests_slimming_paint_v2" to the list of builders for that pool,
above.

Not sure if that would also be a reasonable way to add this builder?

Anyway, now changed the value of pool to "linux_layout_tests_slimming_paint_v2".

https://codereview.chromium.org/2153503006/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/trybots.py (left):

https://codereview.chromium.org/2153503006/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/trybots.py:343:
'linux_site_isolation': simple_bot({
On 2016/07/22 at 13:36:12, Paweł Hajdan (OOO back Aug 1) wrote:
> Did you intend to remove linux_site_isolation? I don't see corresponding
master change so it seems this'd break it.

I didn't intend to remove linux_site_isolation, this was a mistake; thanks for
catching it. Now added back.

[qyearsley, 2016-07-26 17:04:44]

Pawel is now on vacation.

Dirk, does this look OK to submit now?

[qyearsley, 2016-07-26 17:06:11]

Description was changed from

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865;
there are also src-side changes in http://crrev.com/2156633003.

BUG=622865
==========

to

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865.

There are also src-side changes in http://crrev.com/2156633003, now committed.

Bug for master restart: http://crbug.com/631511

BUG=622865
==========

[Dirk Pranke, 2016-07-26 18:40:48]

Why did the linux_site_isolation .json file get deleted?

Also, see my question, below?

https://codereview.chromium.org/2153503006/diff/100001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2153503006/diff/100001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:158: ]),
Do you really want --enable-wptserve here?

[qyearsley, 2016-07-26 22:10:33]

The file full_tryserver_chromium_linux_linux_site_isolation.json was deleted
because I forgot to rerun recipe_simulation_test train after fixing the config
in the previous patch.

That is now removed and the extra args for the new bot is not changed to
"--additional-driver-flag=--enable-slimming-paint-v2".

https://codereview.chromium.org/2153503006/diff/100001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2153503006/diff/100001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:158: ]),
On 2016/07/26 at 18:40:48, Dirk Pranke wrote:
> Do you really want --enable-wptserve here?

Nope; I copied and pasted a section of code and apparently forgot to update it
to have "--additional-driver-flag=--enable-slimming-paint-v2".

[Dirk Pranke, 2016-07-26 22:26:17]

lgtm

[qyearsley, 2016-07-26 23:26:50]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 23:26:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 23:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:32:39]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-27 00:00:24]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:00:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:03:55]

Description was changed from

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865.

There are also src-side changes in http://crrev.com/2156633003, now committed.

Bug for master restart: http://crbug.com/631511

BUG=622865
==========

to

==========
Add config for Linux layout test try bot with --enable-slimming-paint-v2

This CL should contain the build repo changes for http://crbug.com/622865.

There are also src-side changes in http://crrev.com/2156633003, now committed.

Bug for master restart: http://crbug.com/631511

BUG=622865

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/761a85597e4e990fbf96...
==========

[commit-bot: I haz the power, 2016-07-27 00:03:56]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/tools/build/+/761a85597e4e990fbf96...