Issue 21535: An experimental fix for Issue 7707....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21535: An experimental fix for Issue 7707.... (Closed)

Created:
11 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

An experimental fix for Issue 7707. To read crash dumps, it seems a rich-edit control crashes because it receives a WM_IME_CHAR message while it is processing a WM_IME_COMPOSITION message. Since a rich-edit control does not need WM_IME_CHAR messages, this code just blocks WM_IME_CHAR messages from being dispatched to view controls. Even though I'm not totally confident this code fixes this issue, I wish it does. BUG=7707 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10328

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/views/focus_manager.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 10 months ago (2009-02-23 16:38:04 UTC) #2

Is it worth adding a comment as to why you're adding this?
Otherwise LGTM.

Expand Messages | Collapse Messages