Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2153493002: Revert of ash: Refactor touch hud drawing to ash/touch_hud. (Closed)

Created:
4 years, 5 months ago by riajiang
Modified:
4 years, 5 months ago
Reviewers:
James Cook, sadrul, sky, Dan Beam
CC:
chromium-reviews, kalyank, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ash: Refactor touch hud drawing to ash/touch_hud. (patchset #13 id:240001 of https://codereview.chromium.org/2118223004/ ) Reason for revert: Missing dependency, broke build Original issue's description: > ash: Refactor touch hud drawing to ash/touch_hud. > > This is part of the touch hud app for mustash (https://codereview.chromium.org/2092343002/). > > BUG=588311 > TEST=ash_unittests > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win8_chromium_gyp_dbg;master.tryserver.chromium.win:win8_chromium_gyp_rel > > Committed: https://crrev.com/98caac0fdcd637a95eb27e72c9a4c0a487e72d25 > Committed: https://crrev.com/fd4123fd2d8efaa85d0b2f1550ca6e70ddc7cb55 > Cr-Original-Commit-Position: refs/heads/master@{#405296} > Cr-Commit-Position: refs/heads/master@{#405506} TBR=sadrul@chromium.org,sky@chromium.org,jamescook@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588311 Committed: https://crrev.com/245890c8554a952b58287352b94731ef9c2846f2 Cr-Commit-Position: refs/heads/master@{#405525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -328 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/ash.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D ash/ash_touch_hud.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
M ash/touch/touch_hud_projection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/touch/touch_hud_projection.cc View 1 chunk +141 lines, -6 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
D ash/touch_hud/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D ash/touch_hud/ash_touch_hud_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/touch_hud/touch_hud_renderer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ash/touch_hud/touch_hud_renderer.cc View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
riajiang
Created Revert of ash: Refactor touch hud drawing to ash/touch_hud.
4 years, 5 months ago (2016-07-14 18:40:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153493002/1
4 years, 5 months ago (2016-07-14 18:41:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-14 18:41:39 UTC) #5
Dan Beam
lgtm
4 years, 5 months ago (2016-07-14 18:43:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153493002/1
4 years, 5 months ago (2016-07-14 18:44:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 18:45:26 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 18:46:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/245890c8554a952b58287352b94731ef9c2846f2
Cr-Commit-Position: refs/heads/master@{#405525}

Powered by Google App Engine
This is Rietveld 408576698