Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2153453002: Remove now redundant check after an earlier cl added a tighter check. (Closed)

Created:
4 years, 5 months ago by regis
Modified:
4 years, 5 months ago
Reviewers:
siva, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove now redundant check after an earlier cl added a tighter check. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1d50171a9b4834ab2641097370284afba5e75793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M runtime/vm/parser.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
For context, see my reply to Matthias in https://codereview.chromium.org/2139003002/
4 years, 5 months ago (2016-07-14 17:14:39 UTC) #2
siva
lgtm
4 years, 5 months ago (2016-07-14 17:37:19 UTC) #3
regis
4 years, 5 months ago (2016-07-14 17:57:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d50171a9b4834ab2641097370284afba5e75793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698