net/dns/mock_mdns_socket_factory.cc - Issue 21534003: avoid char+'\xHH' as it's too easy to use values > 127

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mock_mdns_socket_factory.cc

Issue 21534003: avoid char+'\xHH' as it's too easy to use values > 127 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mock_mdns_socket_factory.cc

diff --git a/net/dns/mock_mdns_socket_factory.cc b/net/dns/mock_mdns_socket_factory.cc

index 720f6a0d6cd7693cbe42649b3008c854626bea9e..8c08c150cd1dfa7a50556a7dc0991bd67965e594 100644

--- a/net/dns/mock_mdns_socket_factory.cc

+++ b/net/dns/mock_mdns_socket_factory.cc

@@ -84,7 +84,7 @@ scoped_ptr<DatagramServerSocket> MockMDnsSocketFactory::CreateSocket() {

return new_socket.PassAs<DatagramServerSocket>();

}

-void MockMDnsSocketFactory::SimulateReceive(const char* packet, int size) {

+void MockMDnsSocketFactory::SimulateReceive(const uint8* packet, int size) {

DCHECK(recv_buffer_size_ >= size);

DCHECK(recv_buffer_.get());

DCHECK(!recv_callback_.is_null());

« net/dns/mdns_client_unittest.cc ('K') | « net/dns/mock_mdns_socket_factory.h ('k') | net/dns/record_parsed_unittest.cc » ('j') | net/dns/record_rdata_unittest.cc » ('J')