Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2153393002:
Cocoa: Enable controls in the content settings popup based on enterprise settings. (Closed)
|
Created:
4 years, 5 months ago by tapted Modified:
4 years, 5 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCocoa: Enable controls in the content settings popup based on enterprise settings.
r141724 added code to the toolkit-views content settings bubble to
disable the radio buttons on a content settings popup if the setting was
controlled by enterprise policy, but this never made it to Cocoa.
Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass
the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled.
Screenshot at http://crbug.com/509249#c30
BUG=509249, 98029
Committed: https://crrev.com/2f31973596db77e508ab0ab46d034537e04f7585
Cr-Commit-Position: refs/heads/master@{#405980}
Patch Set 1 : fix #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. Do this by calling setEnabled on the NSMatrix of radio buttons, passing the value of ContentSettingBubbleModel::BubbleContent::radio_group_enabled. BUG=509249 ========== to ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. BUG=509249, 98029 ==========
Description was changed from ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. BUG=509249, 98029 ========== to ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 ==========
tapted@chromium.org changed reviewers: + bauerb@chromium.org
Hi Bernhard, please take a look
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks!
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 ========== to ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 ========== to ========== Cocoa: Enable controls in the content settings popup based on enterprise settings. r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 Committed: https://crrev.com/2f31973596db77e508ab0ab46d034537e04f7585 Cr-Commit-Position: refs/heads/master@{#405980} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2f31973596db77e508ab0ab46d034537e04f7585 Cr-Commit-Position: refs/heads/master@{#405980} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
