Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2153383003: LogDog: Actually use default max buffer age. (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Actually use default max buffer age. The documentation for the MaxBufferAge parameter suggests that if it's zero, a default value will be used. However, this was not actually implemented. Historically this has not been a problem, since the only user always supplied a non-zero value, but now that Butler is being used elsewhere as a library, let's fix this. TBR=hinoka@chromium.org BUG=chromium:628321 TEST=None Committed: https://github.com/luci/luci-go/commit/ac277ae13b4b040d504162c4dc6f6bd08de5149e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M client/logdog/butler/butler.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153383003/1
4 years, 5 months ago (2016-07-18 19:24:59 UTC) #2
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:45:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ac277ae13b4b040d504162c4dc6f6bd08de5149e

Powered by Google App Engine
This is Rietveld 408576698