content/common/dwrite_font_proxy_messages.h - Issue 2153343002: Implement support for loading font files from outside system directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/dwrite_font_proxy_messages.h

Issue 2153343002: Implement support for loading font files from outside system directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some more comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc ('K') | « content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc ('k') | content/test/dwrite_font_fake_sender_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/dwrite_font_proxy_messages.h

diff --git a/content/common/dwrite_font_proxy_messages.h b/content/common/dwrite_font_proxy_messages.h

index 288a3cf0d05cb300b8ff35a0499e567997b3afed..027ce3387a1c561356beda0d56c47f2e9753b672 100644

--- a/content/common/dwrite_font_proxy_messages.h

+++ b/content/common/dwrite_font_proxy_messages.h

@@ -10,6 +10,7 @@

#include "base/strings/string16.h"

#include "content/common/content_export.h"

#include "ipc/ipc_message_macros.h"

+#include "ipc/ipc_platform_file.h"

#undef IPC_MESSAGE_EXPORT

#define IPC_MESSAGE_EXPORT CONTENT_EXPORT

@@ -55,9 +56,11 @@ IPC_SYNC_MESSAGE_CONTROL1_1(

// Returns the list of font file paths in the system font directory that contain

// font data for the font family at the specified index.

-IPC_SYNC_MESSAGE_CONTROL1_1(DWriteFontProxyMsg_GetFontFiles,

- uint32_t /* family_index */,

- std::vector<base::string16> /* out file_paths */)

+IPC_SYNC_MESSAGE_CONTROL1_2(

+ DWriteFontProxyMsg_GetFontFiles,

+ uint32_t /* family_index */,

+ std::vector<base::string16> /* out file_paths */,

+ std::vector<IPC::PlatformFileForTransit> /* out file_handles*/)

// Locates a font family that is able to render the specified text using the

// specified style. If successful, the family_index and family_name will