[css-tables] Clean up code that detects significant border changes

third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

Index: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
index b0ca3aaea220adc1d37963604f08dfeed2533c95..ec4719d46a50bfb25e3432bcd9c0ba203bb75af9 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
@@ -4,6 +4,7 @@
 
 #include "core/layout/LayoutTableBoxComponent.h"
 
+#include "core/layout/LayoutTable.h"
 #include "core/style/ComputedStyle.h"
 
 namespace blink {
@@ -25,4 +26,13 @@ void LayoutTableBoxComponent::imageChanged(WrappedImagePtr, const IntRect*)
     m_backgroundChangedSinceLastPaintInvalidation = true;
 }
 
+/*static*/ bool LayoutTableBoxComponent::doCellsHaveDirtyWidth(const LayoutObject& tablePart, const LayoutTable& table, const StyleDifference& diff, const ComputedStyle& oldStyle)

[eae, 2016/07/18 16:21:53]

Uncomment or remove static modifier.

[dgrogan, 2016/07/18 17:24:27]

I removed it... it's only allowed to be specified in the class definition so
uncommenting isn't viable.

+{
+    // ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation sets needsFullLayout when border sizes
+    // change: checking diff.needsFullLayout() is an optimization, not required for correctness.
+    // TODO(dgrogan): Remove tablePart.needsLayout()? Perhaps it was an old optimization but now it
+    // seems that diff.needsFullLayout() implies tablePart.needsLayout().
+    return diff.needsFullLayout() && tablePart.needsLayout() && table.collapseBorders() && !oldStyle.border().sizeEquals(tablePart.style()->border());
+}
+
 } // namespace blink