[css-tables] Clean up code that detects significant border changes

[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
Committed: https://crrev.com/40bb88335c64b80aea9326ef3cf6220dcd90c1bc
Cr-Commit-Position: refs/heads/master@{#406051}

[dgrogan, 2016-07-16 01:29:18]

Description was changed from

==========
fixed merge?

BUG=
==========

to

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

[dgrogan, 2016-07-16 01:29:37]

Patchset #1 (id:1) has been deleted

[dgrogan, 2016-07-16 01:31:34]

Description was changed from

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

to

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

[dgrogan, 2016-07-16 01:32:23]

dgrogan@chromium.org changed reviewers:
+ eae@chromium.org

[dgrogan, 2016-07-16 01:32:24]

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/BorderData.h (right):

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/BorderData.h:127: bool sizeEquals(const
BorderData& o) const
Yup, screwed this up.

[eae, 2016-07-18 16:21:54]

LGTM w/nit

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp (right):

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp:29: /*static*/
bool LayoutTableBoxComponent::doCellsHaveDirtyWidth(const LayoutObject&
tablePart, const LayoutTable& table, const StyleDifference& diff, const
ComputedStyle& oldStyle)
Uncomment or remove static modifier.

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/BorderData.h (right):

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/BorderData.h:127: bool sizeEquals(const
BorderData& o) const
On 2016/07/16 01:32:24, dgrogan wrote:
> Yup, screwed this up.

Acknowledged.

[dgrogan, 2016-07-18 17:22:58]

The CQ bit was checked by dgrogan@chromium.org

[dgrogan, 2016-07-18 17:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2153283002/#ps40001
(title: "remove /*static*/")

[commit-bot: I haz the power, 2016-07-18 17:23:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgrogan, 2016-07-18 17:24:27]

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp (right):

https://codereview.chromium.org/2153283002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp:29: /*static*/
bool LayoutTableBoxComponent::doCellsHaveDirtyWidth(const LayoutObject&
tablePart, const LayoutTable& table, const StyleDifference& diff, const
ComputedStyle& oldStyle)
On 2016/07/18 16:21:53, eae wrote:
> Uncomment or remove static modifier.

I removed it... it's only allowed to be specified in the class definition so
uncommenting isn't viable.

[commit-bot: I haz the power, 2016-07-18 18:57:52]

Description was changed from

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

to

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

[commit-bot: I haz the power, 2016-07-18 18:57:53]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-18 19:01:27]

Description was changed from

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728
==========

to

==========
[css-tables] Clean up code that detects significant border changes

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728

Committed: https://crrev.com/40bb88335c64b80aea9326ef3cf6220dcd90c1bc
Cr-Commit-Position: refs/heads/master@{#406051}
==========

[commit-bot: I haz the power, 2016-07-18 19:01:28]

Patchset 2 (id:??) landed as
https://crrev.com/40bb88335c64b80aea9326ef3cf6220dcd90c1bc
Cr-Commit-Position: refs/heads/master@{#406051}