DevTools: [SSP] simplify Control-Click functionality

DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman

Committed: https://crrev.com/1ebd26d0dbc4c47ba9233f5e5c643eeb031afea2
Cr-Commit-Position: refs/heads/master@{#407076}

[lushnikov, 2016-07-15 22:35:27]

Description was changed from

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch simplifies this functionality.

BUG=none
R=pfeldman
==========

to

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman
==========

[lushnikov, 2016-07-15 22:36:28]

please, take a look

[lushnikov, 2016-07-15 22:36:51]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 22:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:39:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-07-18 17:47:10]

rebaselined.

please, take another look

[lushnikov, 2016-07-18 17:47:15]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 17:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-07-18 18:22:19]

https://codereview.chromium.org/2153263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(left):

https://codereview.chromium.org/2153263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:527:
if ((!WebInspector.isMac() && event.keyCode ===
WebInspector.KeyboardShortcut.Keys.Ctrl.code) ||
What happened to this code?

[commit-bot: I haz the power, 2016-07-18 19:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:38:44]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-07-19 01:19:48]

https://codereview.chromium.org/2153263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(left):

https://codereview.chromium.org/2153263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:527:
if ((!WebInspector.isMac() && event.keyCode ===
WebInspector.KeyboardShortcut.Keys.Ctrl.code) ||
On 2016/07/18 18:22:19, pfeldman wrote:
> What happened to this code?

Usually, mouse has at least a minor movement when you hit "ctrl", so the
mousemove handler gets executed.

[pfeldman, 2016-07-21 21:32:53]

> Usually, mouse has at least a minor movement when you hit "ctrl", so the
> mousemove handler gets executed.

Hm?

[pfeldman, 2016-07-21 21:57:44]

lgtm

[lushnikov, 2016-07-21 23:03:06]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:03:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 23:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:06:20]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[lushnikov, 2016-07-22 03:20:07]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-07-22 03:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2153263002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-07-22 03:20:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 05:51:11]

Description was changed from

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman
==========

to

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman
==========

[commit-bot: I haz the power, 2016-07-22 05:51:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 05:53:57]

Description was changed from

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman
==========

to

==========
DevTools: [SSP] simplify Control-Click functionality

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman

Committed: https://crrev.com/1ebd26d0dbc4c47ba9233f5e5c643eeb031afea2
Cr-Commit-Position: refs/heads/master@{#407076}
==========

[commit-bot: I haz the power, 2016-07-22 05:53:59]

Patchset 3 (id:??) landed as
https://crrev.com/1ebd26d0dbc4c47ba9233f5e5c643eeb031afea2
Cr-Commit-Position: refs/heads/master@{#407076}