Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 2153243002: MD Settings: Replace paper-item with button under passwords_and_forms_page/. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Replace paper-item with button under passwords_and_forms_page/. BUG=626989, 602896 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5 Cr-Commit-Position: refs/heads/master@{#405924}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Fixing test assertions to ignore spaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 3 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js View 1 chunk +12 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 2 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
dpapad
4 years, 5 months ago (2016-07-15 21:57:27 UTC) #7
hcarmona
lgtm
4 years, 5 months ago (2016-07-15 22:21:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153243002/20001
4 years, 5 months ago (2016-07-15 22:24:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/263797)
4 years, 5 months ago (2016-07-15 23:06:14 UTC) #13
dpapad
FYI, had to update tests to use trim() when testing dropdown option contents, because <button> ...
4 years, 5 months ago (2016-07-16 00:48:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153243002/40001
4 years, 5 months ago (2016-07-16 00:51:15 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-16 02:37:20 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 02:39:29 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5
Cr-Commit-Position: refs/heads/master@{#405924}

Powered by Google App Engine
This is Rietveld 408576698