Issue 215323003: Let the overlay playback button fall back to the activation behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215323003: Let the overlay playback button fall back to the activation behavior (Closed)

Created:
6 years, 8 months ago by philipj_slow

Modified:
6 years, 8 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Let the overlay playback button fall back to the activation behavior Since the button is only visible when togglePlayStateWillPlay(), just doing nothing and falling back to the default activation behavior will do the right thing. BUG=354746 TEST=LayoutTests/media/activation-behavior-shadow.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170789

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	Source/core/html/shadow/MediaControlElements.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/html/shadow/MediaControlElements.cpp	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

I remembered this while looking at https://code.google.com/p/chromium/issues/detail?id=358675 although I concluded that it's not related.

6 years, 8 months ago (2014-04-02 19:32:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/215323003/1

6 years, 8 months ago (2014-04-03 19:15:06 UTC) #4

Message was sent while issue was closed.

Change committed as 170789

Expand Messages | Collapse Messages