Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: runtime/bin/extensions.cc

Issue 2153203002: Strip the scheme off of uris passed into the native extension loader. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rmacnak review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions.cc
diff --git a/runtime/bin/extensions.cc b/runtime/bin/extensions.cc
index f4b921f9cac63061f02690eccd686ef2d439b2fb..d319ce771c1d0d85155d0f960c85911321943c81 100644
--- a/runtime/bin/extensions.cc
+++ b/runtime/bin/extensions.cc
@@ -19,11 +19,6 @@ namespace bin {
Dart_Handle Extensions::LoadExtension(const char* extension_directory,
const char* extension_name,
Dart_Handle parent_library) {
- if (strncmp(extension_directory, "http://", 7) == 0 ||
- strncmp(extension_directory, "https://", 8) == 0) {
- return Dart_NewApiError("Cannot load native extensions over http:");
- }
-
// For example on Linux: directory/libfoo-arm.so
const char* library_strings[] = {
extension_directory, // directory/
« no previous file with comments | « no previous file | runtime/bin/loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698