Strip the scheme off of uris passed into the native extension loader.

Strip the scheme off of uris passed into the native extension loader.

Fixes https://github.com/dart-lang/sdk/issues/26894

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/7af8d6e5a4f981e06a29e28db180ca4badd2f0f9

[Cutch, 2016-07-15 18:10:12]

Description was changed from

==========
Strip the scheme off of uris passed into the native extension loader.

BUG=
==========

to

==========
Strip the scheme off of uris passed into the native extension loader.

BUG=
==========

[Cutch, 2016-07-15 18:10:12]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[Cutch, 2016-07-15 18:10:31]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-07-15 18:10:42]

Description was changed from

==========
Strip the scheme off of uris passed into the native extension loader.

BUG=
==========

to

==========
Strip the scheme off of uris passed into the native extension loader.

Fixes https://github.com/dart-lang/sdk/issues/26894

BUG=
==========

[rmacnak, 2016-07-15 19:28:30]

https://codereview.chromium.org/2153203002/diff/20001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2153203002/diff/20001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:310: Dart_Handle result =
Extensions::LoadExtension(lib_path,
This bypasses the check for http or https in LoadExtension.

Should this change apply to DartUtils::LibraryTagHandler as well? Maybe push
removing the scheme into LoadExtension.

[Cutch, 2016-07-15 19:58:43]

https://codereview.chromium.org/2153203002/diff/20001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2153203002/diff/20001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:310: Dart_Handle result =
Extensions::LoadExtension(lib_path,
On 2016/07/15 19:28:30, rmacnak wrote:
> This bypasses the check for http or https in LoadExtension.
> 

Done.

> Should this change apply to DartUtils::LibraryTagHandler as well? Maybe push
> removing the scheme into LoadExtension.

DartUtils::LibraryTagHandler is unused and I'll delete it in a future CL.

[rmacnak, 2016-07-15 19:59:45]

lgtm

[Cutch, 2016-07-15 20:09:37]

Description was changed from

==========
Strip the scheme off of uris passed into the native extension loader.

Fixes https://github.com/dart-lang/sdk/issues/26894

BUG=
==========

to

==========
Strip the scheme off of uris passed into the native extension loader.

Fixes https://github.com/dart-lang/sdk/issues/26894

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7af8d6e5a4f981e06a29e28db180ca4badd2f0f9
==========

[Cutch, 2016-07-15 20:09:39]

Committed patchset #3 (id:40001) manually as
7af8d6e5a4f981e06a29e28db180ca4badd2f0f9 (presubmit successful).