Issue 21532002: CORS: Handle error HTTP status code 4XX/5XX in preflight requests.

Issue 21532002: CORS: Handle error HTTP status code 4XX/5XX in preflight requests. (Closed)

Created:
7 years, 4 months ago by ancilgeorge

Modified:
7 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), bbudge, bbudge-google, abarth-chromium

CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

CORS: Handle error HTTP status code 4XX/5XX in preflight requests. As per the W33 CORS Spec http://www.w3.org/TR/cors/#cross-origin-request-with-preflight-0 'network error'should be triggered when the response is a error status code (4XX/5XX) Also refer http://fetch.spec.whatwg.org/#cors-preflight-fetch-0. However when response with such status code was received it was treated as success and the actual request was made. Added code check the error status code and send 'network error' in case of preflight requests. This makes the behavior consistent with Mozilla Firefox Browser. Also clears the failures in http://w3c-test.org/webappsec/tests/cors/submitted/opera/staging/status.htm http://w3c-test.org/webappsec/tests/cors/submitted/opera/staging/status-async.htm BUG=266807 R=abarth@chromium.org, kbr@chromium.org, bbudge@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155413

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -0 lines)			Patch
A	LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400.html	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400-expected.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-501.html	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-501-expected.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/xmlhttprequest/resources/access-control-preflight-request-invalid-status.php	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	Source/core/loader/CrossOriginAccessControl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/loader/CrossOriginAccessControl.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/loader/DocumentThreadableLoader.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ancilgeorge@samsung.com/21532002/1

7 years, 4 months ago (2013-08-01 16:42:25 UTC) #4

bbudge-google

LGTM https://codereview.chromium.org/21532002/diff/1/Source/core/loader/CrossOriginAccessControl.cpp File Source/core/loader/CrossOriginAccessControl.cpp (right): https://codereview.chromium.org/21532002/diff/1/Source/core/loader/CrossOriginAccessControl.cpp#newcode172 Source/core/loader/CrossOriginAccessControl.cpp:172: errorDescription = "Invalid HTTP status code " + ...

7 years, 4 months ago (2013-08-01 16:48:08 UTC) #5

ancilgeorge

https://codereview.chromium.org/21532002/diff/1/Source/core/loader/CrossOriginAccessControl.cpp File Source/core/loader/CrossOriginAccessControl.cpp (right): https://codereview.chromium.org/21532002/diff/1/Source/core/loader/CrossOriginAccessControl.cpp#newcode172 Source/core/loader/CrossOriginAccessControl.cpp:172: errorDescription = "Invalid HTTP status code " + String::number(response.httpStatusCode()); ...

7 years, 4 months ago (2013-08-02 04:35:06 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ancilgeorge@samsung.com/21532002/14001

7 years, 4 months ago (2013-08-02 04:35:19 UTC) #8

Message was sent while issue was closed.

Change committed as 155413

Expand Messages | Collapse Messages