Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 2153163002: Don't run Analysis Server performance tests in checked mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/benchmark/perf/performance_tests.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index 9e764a0711d97b9ce4a3dff253f62c5e01cce13a..9835a1e2a3540f5b23387056c6cad6975989adb9 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -205,8 +205,8 @@ abstract class AbstractAnalysisServerIntegrationTest
/**
* Start [server].
*/
- Future startServer({int servicesPort}) =>
- server.start(servicesPort: servicesPort);
+ Future startServer({int servicesPort, bool checked: true}) =>
+ server.start(servicesPort: servicesPort, checked: checked);
/**
* After every test, the server is stopped and [sourceDirectory] is deleted.
@@ -601,6 +601,7 @@ class Server {
int diagnosticPort,
bool profileServer: false,
int servicesPort,
+ bool checked: true,
bool useAnalysisHighlight2: false}) {
if (_process != null) {
throw new Exception('Process already started');
@@ -627,7 +628,9 @@ class Server {
if (Platform.packageRoot != null) {
arguments.add('--package-root=${Platform.packageRoot}');
}
- arguments.add('--checked');
+ if (checked) {
+ arguments.add('--checked');
+ }
arguments.add(serverPath);
if (diagnosticPort != null) {
arguments.add('--port');
« no previous file with comments | « pkg/analysis_server/benchmark/perf/performance_tests.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698