DevTools: remove dead code, disambiguate expand for sections.

third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 38 matching lines @@
     toolbar: function()
     {
         if (!this._toolbar) {
             this._toolbar = new WebInspector.Toolbar("");
             this._toolbar.element.addEventListener("click", consumeEvent);
             this.element.insertBefore(this._toolbar.element, this.element.firstChild);
         }
         return this._toolbar;
     },
 
-    /**
-     * @return {string}
-     */
-    title: function()
-    {
-        return this._title;
-    },
-
-    expand: function()
+    expandPane: function()
     {
         this.onContentReady();
     },
 
     onContentReady: function()
     {
         if (this._expandCallback)
             this._expandCallback();
         else
             this._expandPending = true;
@@ skipping 31 matching lines @@
 /**
  * @constructor
  * @param {!Element} container
  * @param {!WebInspector.SidebarPane} pane
  */
 WebInspector.SidebarPaneTitle = function(container, pane)
 {
     this._pane = pane;
 
     this.element = container.createChild("div", "sidebar-pane-title");
-    this.element.textContent = pane.title();
+    this.element.textContent = pane._title;
     this.element.tabIndex = 0;
     this.element.addEventListener("click", this._toggleExpanded.bind(this), false);
     this.element.addEventListener("keydown", this._onTitleKeyDown.bind(this), false);
 }
 
 WebInspector.SidebarPaneTitle.prototype = {
     _expand: function()
     {
         this.element.classList.add("expanded");
         this._pane.show(this.element.parentElement, /** @type {?Element} */ (this.element.nextSibling));
     },
 
     _collapse: function()
     {
         this.element.classList.remove("expanded");
         if (this._pane.element.parentNode === this.element.parentNode)
             this._pane.detach();
     },
 
     _toggleExpanded: function()
     {
         if (this.element.classList.contains("expanded"))
             this._collapse();
         else
-            this._pane.expand();
+            this._pane.expandPane();
     },
 
     /**
      * @param {!Event} event
      */
     _onTitleKeyDown: function(event)
     {
         if (isEnterKey(event) || event.keyCode === WebInspector.KeyboardShortcut.Keys.Space.code)
             this._toggleExpanded();
     }
@@ skipping 51 matching lines @@
     WebInspector.TabbedPane.call(this);
     this.element.classList.add("sidebar-tabbed-pane");
 }
 
 WebInspector.SidebarTabbedPane.prototype = {
     /**
      * @param {!WebInspector.SidebarPane} pane
      */
     addPane: function(pane)
     {
-        var title = pane.title();
+        var title = pane._title;
         this.appendTab(title, title, pane);
         if (pane._toolbar)
             pane.element.insertBefore(pane._toolbar.element, pane.element.firstChild);
         pane._attached(this._setPaneVisible.bind(this, pane), this.selectTab.bind(this, title));
     },
 
     /**
      * @param {!WebInspector.SidebarPane} pane
      * @param {boolean} visible
      */
     _setPaneVisible: function(pane, visible)
     {
         var title = pane._title;
         if (visible) {
             if (!this.hasTab(title))
                 this.appendTab(title, title, pane);
         } else {
             if (this.hasTab(title))
                 this.closeTab(title);
         }
     },
 
     __proto__: WebInspector.TabbedPane.prototype
 }