Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) IBM Corp. 2009 All rights reserved. 2 * Copyright (C) IBM Corp. 2009 All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 { 68 {
69 this._requiresUpdate = true; 69 this._requiresUpdate = true;
70 this._refreshExpressionsIfNeeded(); 70 this._refreshExpressionsIfNeeded();
71 }, 71 },
72 72
73 /** 73 /**
74 * @param {string} expressionString 74 * @param {string} expressionString
75 */ 75 */
76 addExpression: function(expressionString) 76 addExpression: function(expressionString)
77 { 77 {
78 this.expand(); 78 this.expandPane();
79 if (this._requiresUpdate) { 79 if (this._requiresUpdate) {
80 this._rebuildWatchExpressions(); 80 this._rebuildWatchExpressions();
81 delete this._requiresUpdate; 81 delete this._requiresUpdate;
82 } 82 }
83 this._createWatchExpression(expressionString); 83 this._createWatchExpression(expressionString);
84 this._saveExpressions(); 84 this._saveExpressions();
85 }, 85 },
86 86
87 expandIfNecessary: function() 87 expandIfNecessary: function()
88 { 88 {
89 if (this._watchExpressionsSetting.get().length) 89 if (this._watchExpressionsSetting.get().length)
90 this.expand(); 90 this.expandPane();
91 }, 91 },
92 92
93 _saveExpressions: function() 93 _saveExpressions: function()
94 { 94 {
95 var toSave = []; 95 var toSave = [];
96 for (var i = 0; i < this._watchExpressions.length; i++) 96 for (var i = 0; i < this._watchExpressions.length; i++)
97 if (this._watchExpressions[i].expression()) 97 if (this._watchExpressions[i].expression())
98 toSave.push(this._watchExpressions[i].expression()); 98 toSave.push(this._watchExpressions[i].expression());
99 99
100 this._watchExpressionsSetting.set(toSave); 100 this._watchExpressionsSetting.set(toSave);
101 }, 101 },
102 102
103 _refreshExpressionsIfNeeded: function() 103 _refreshExpressionsIfNeeded: function()
104 { 104 {
105 if (this._requiresUpdate && this.isShowing()) { 105 if (this._requiresUpdate && this.isShowing()) {
106 this._rebuildWatchExpressions(); 106 this._rebuildWatchExpressions();
107 delete this._requiresUpdate; 107 delete this._requiresUpdate;
108 } else 108 } else
109 this._requiresUpdate = true; 109 this._requiresUpdate = true;
110 }, 110 },
111 111
112 /** 112 /**
113 * @param {!WebInspector.Event=} event 113 * @param {!WebInspector.Event=} event
114 */ 114 */
115 _addButtonClicked: function(event) 115 _addButtonClicked: function(event)
116 { 116 {
117 if (event) 117 if (event)
118 event.consume(true); 118 event.consume(true);
119 this.expand(); 119 this.expandPane();
120 this._createWatchExpression(null).startEditing(); 120 this._createWatchExpression(null).startEditing();
121 }, 121 },
122 122
123 /** 123 /**
124 * @param {!WebInspector.Event} event 124 * @param {!WebInspector.Event} event
125 */ 125 */
126 _refreshButtonClicked: function(event) 126 _refreshButtonClicked: function(event)
127 { 127 {
128 event.consume(); 128 event.consume();
129 this.refreshExpressions(); 129 this.refreshExpressions();
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 contextMenu.appendApplicableItems(this._result); 436 contextMenu.appendApplicableItems(this._result);
437 }, 437 },
438 438
439 _copyValueButtonClicked: function() 439 _copyValueButtonClicked: function()
440 { 440 {
441 InspectorFrontendHost.copyText(this._valueElement.textContent); 441 InspectorFrontendHost.copyText(this._valueElement.textContent);
442 }, 442 },
443 443
444 __proto__: WebInspector.Object.prototype 444 __proto__: WebInspector.Object.prototype
445 } 445 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698