Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.CallFrameSelected, this._callFrameSelectedInSidebar.bind(this)); 80 this.sidebarPanes.callstack.addEventListener(WebInspector.CallStackSidebarPa ne.Events.CallFrameSelected, this._callFrameSelectedInSidebar.bind(this));
81 this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(th is)); 81 this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(th is));
82 82
83 this.sidebarPanes.scopechain = new WebInspector.ScopeChainSidebarPane(); 83 this.sidebarPanes.scopechain = new WebInspector.ScopeChainSidebarPane();
84 this.sidebarPanes.jsBreakpoints = new WebInspector.JavaScriptBreakpointsSide barPane(WebInspector.breakpointManager, this.showUISourceCode.bind(this)); 84 this.sidebarPanes.jsBreakpoints = new WebInspector.JavaScriptBreakpointsSide barPane(WebInspector.breakpointManager, this.showUISourceCode.bind(this));
85 this.sidebarPanes.domBreakpoints = WebInspector.domBreakpointsSidebarPane.cr eateProxy(this); 85 this.sidebarPanes.domBreakpoints = WebInspector.domBreakpointsSidebarPane.cr eateProxy(this);
86 this.sidebarPanes.xhrBreakpoints = new WebInspector.XHRBreakpointsSidebarPan e(); 86 this.sidebarPanes.xhrBreakpoints = new WebInspector.XHRBreakpointsSidebarPan e();
87 this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerB reakpointsSidebarPane(); 87 this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerB reakpointsSidebarPane();
88 this.sidebarPanes.objectEventListeners = new WebInspector.ObjectEventListene rsSidebarPane(); 88 this.sidebarPanes.objectEventListeners = new WebInspector.ObjectEventListene rsSidebarPane();
89 89
90 this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("las tSelectedSourcesSidebarPaneTab", this.sidebarPanes.scopechain.title()); 90 this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("las tSelectedSourcesSidebarPaneTab", WebInspector.UIString("Scope"));
91 91
92 this._installDebuggerSidebarController(); 92 this._installDebuggerSidebarController();
93 93
94 WebInspector.moduleSetting("sidebarPosition").addChangeListener(this._update SidebarPosition.bind(this)); 94 WebInspector.moduleSetting("sidebarPosition").addChangeListener(this._update SidebarPosition.bind(this));
95 this._updateSidebarPosition(); 95 this._updateSidebarPosition();
96 96
97 this._updateDebuggerButtons(); 97 this._updateDebuggerButtons();
98 this._pauseOnExceptionEnabledChanged(); 98 this._pauseOnExceptionEnabledChanged();
99 WebInspector.moduleSetting("pauseOnExceptionEnabled").addChangeListener(this ._pauseOnExceptionEnabledChanged, this); 99 WebInspector.moduleSetting("pauseOnExceptionEnabled").addChangeListener(this ._pauseOnExceptionEnabledChanged, this);
100 100
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 sidebarPaneStack.show(vbox.element); 1097 sidebarPaneStack.show(vbox.element);
1098 vbox.element.appendChild(this._debugToolbar.element); 1098 vbox.element.appendChild(this._debugToolbar.element);
1099 1099
1100 if (!vertically) { 1100 if (!vertically) {
1101 // Populate the only stack. 1101 // Populate the only stack.
1102 for (var pane in this.sidebarPanes) 1102 for (var pane in this.sidebarPanes)
1103 sidebarPaneStack.addPane(this.sidebarPanes[pane]); 1103 sidebarPaneStack.addPane(this.sidebarPanes[pane]);
1104 this._extensionSidebarPanesContainer = sidebarPaneStack; 1104 this._extensionSidebarPanesContainer = sidebarPaneStack;
1105 this.sidebarPaneView = vbox; 1105 this.sidebarPaneView = vbox;
1106 1106
1107 this.sidebarPanes.scopechain.expand(); 1107 this.sidebarPanes.scopechain.expandPane();
1108 this.sidebarPanes.watchExpressions.expandIfNecessary(); 1108 this.sidebarPanes.watchExpressions.expandIfNecessary();
1109 } else { 1109 } else {
1110 var splitWidget = new WebInspector.SplitWidget(true, true, "sourcesP anelDebuggerSidebarSplitViewState", 0.5); 1110 var splitWidget = new WebInspector.SplitWidget(true, true, "sourcesP anelDebuggerSidebarSplitViewState", 0.5);
1111 splitWidget.setMainWidget(vbox); 1111 splitWidget.setMainWidget(vbox);
1112 1112
1113 // Populate the left stack. 1113 // Populate the left stack.
1114 sidebarPaneStack.addPane(this.sidebarPanes.threads); 1114 sidebarPaneStack.addPane(this.sidebarPanes.threads);
1115 sidebarPaneStack.addPane(this.sidebarPanes.callstack); 1115 sidebarPaneStack.addPane(this.sidebarPanes.callstack);
1116 sidebarPaneStack.addPane(this.sidebarPanes.jsBreakpoints); 1116 sidebarPaneStack.addPane(this.sidebarPanes.jsBreakpoints);
1117 sidebarPaneStack.addPane(this.sidebarPanes.domBreakpoints); 1117 sidebarPaneStack.addPane(this.sidebarPanes.domBreakpoints);
(...skipping 11 matching lines...) Expand all
1129 tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabSe lected, this._tabSelected, this); 1129 tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabSe lected, this._tabSelected, this);
1130 this._extensionSidebarPanesContainer = tabbedPane; 1130 this._extensionSidebarPanesContainer = tabbedPane;
1131 this.sidebarPaneView = splitWidget; 1131 this.sidebarPaneView = splitWidget;
1132 } 1132 }
1133 1133
1134 var extensionSidebarPanes = WebInspector.extensionServer.sidebarPanes(); 1134 var extensionSidebarPanes = WebInspector.extensionServer.sidebarPanes();
1135 for (var i = 0; i < extensionSidebarPanes.length; ++i) 1135 for (var i = 0; i < extensionSidebarPanes.length; ++i)
1136 this._addExtensionSidebarPane(extensionSidebarPanes[i]); 1136 this._addExtensionSidebarPane(extensionSidebarPanes[i]);
1137 1137
1138 this._splitWidget.setSidebarWidget(this.sidebarPaneView); 1138 this._splitWidget.setSidebarWidget(this.sidebarPaneView);
1139 this.sidebarPanes.threads.expand(); 1139 this.sidebarPanes.threads.expandPane();
1140 this.sidebarPanes.jsBreakpoints.expand(); 1140 this.sidebarPanes.jsBreakpoints.expandPane();
1141 this.sidebarPanes.callstack.expand(); 1141 this.sidebarPanes.callstack.expandPane();
1142 }, 1142 },
1143 1143
1144 /** 1144 /**
1145 * @param {!WebInspector.Event} event 1145 * @param {!WebInspector.Event} event
1146 */ 1146 */
1147 _tabSelected: function(event) 1147 _tabSelected: function(event)
1148 { 1148 {
1149 this._lastSelectedTabSetting.set(event.data.tabId); 1149 this._lastSelectedTabSetting.set(event.data.tabId);
1150 }, 1150 },
1151 1151
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
1470 __proto__: WebInspector.VBox.prototype 1470 __proto__: WebInspector.VBox.prototype
1471 } 1471 }
1472 1472
1473 /** 1473 /**
1474 * @return {boolean} 1474 * @return {boolean}
1475 */ 1475 */
1476 WebInspector.SourcesPanel.WrapperView.isShowing = function() 1476 WebInspector.SourcesPanel.WrapperView.isShowing = function()
1477 { 1477 {
1478 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing(); 1478 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing();
1479 } 1479 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698