Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2153143002: Rework how enums are implemented and reloaded (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework how enums are implemented and reloaded - Enum instances now hold their index and their label. Before the labels were held in a static array to the side and the index was used to look up the label. - Before and after reload enum instances are now paired (by label) and put into the 'become' table. Fixes https://github.com/dart-lang/sdk/issues/26877 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c692a64e5ad9674d2def15e85da24f71f5f40f8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -318 lines) Patch
M runtime/lib/core_patch.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/isolate_reload.h View 4 chunks +14 lines, -2 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 9 chunks +32 lines, -3 lines 0 comments Download
M runtime/vm/isolate_reload_test.cc View 2 chunks +5 lines, -101 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/object_reload.cc View 6 chunks +127 lines, -169 lines 0 comments Download
M runtime/vm/parser.cc View 6 chunks +35 lines, -30 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 5 months ago (2016-07-15 15:03:09 UTC) #3
rmacnak
LGTM
4 years, 5 months ago (2016-07-15 16:59:33 UTC) #4
Cutch
4 years, 5 months ago (2016-07-15 17:52:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c692a64e5ad9674d2def15e85da24f71f5f40f8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698