chrome/browser/media/media_stream_devices_controller.cc - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_stream_devices_controller.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_android.cc ('k') | chrome/browser/permissions/permission_context_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/media_stream_devices_controller.cc

diff --git a/chrome/browser/media/media_stream_devices_controller.cc b/chrome/browser/media/media_stream_devices_controller.cc

index 62144e7c308eaf60e18acc8b73213dcef83ba819..11d6df9543535a0caf3181bbc1b53d847fec3ef2 100644

--- a/chrome/browser/media/media_stream_devices_controller.cc

+++ b/chrome/browser/media/media_stream_devices_controller.cc

@@ -72,14 +72,20 @@ bool ContentTypeIsRequested(content::PermissionType type,

}

using PermissionActionCallback =

- base::Callback<void(content::PermissionType, const GURL&, Profile*)>;

+ base::Callback<void(content::PermissionType,

+ PermissionRequestGestureType,

+ const GURL&,

+ Profile*)>;

void RecordSinglePermissionAction(const content::MediaStreamRequest& request,

content::PermissionType permission_type,

Profile* profile,

PermissionActionCallback callback) {

if (ContentTypeIsRequested(permission_type, request)) {

- callback.Run(permission_type, request.security_origin, profile);

+ // TODO(stefanocs): Pass the actual |gesture_type| once this file has been

+ // refactored into PermissionContext.

+ callback.Run(permission_type, PermissionRequestGestureType::UNKNOWN,

+ request.security_origin, profile);

}