Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4304)

Unified Diff: chrome/browser/media/media_stream_devices_controller.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_stream_devices_controller.cc
diff --git a/chrome/browser/media/media_stream_devices_controller.cc b/chrome/browser/media/media_stream_devices_controller.cc
index 62144e7c308eaf60e18acc8b73213dcef83ba819..e5782e3c1190016f8dc3347976ecf240d5cd3627 100644
--- a/chrome/browser/media/media_stream_devices_controller.cc
+++ b/chrome/browser/media/media_stream_devices_controller.cc
@@ -71,15 +71,20 @@ bool ContentTypeIsRequested(content::PermissionType type,
return false;
}
-using PermissionActionCallback =
- base::Callback<void(content::PermissionType, const GURL&, Profile*)>;
+using PermissionActionCallback = base::Callback<void(content::PermissionType,
+ bool /* user_gesture */,
Sergey Ulanov 2016/07/21 19:32:47 nit: don't need to have the name commented (and ca
stefanocs 2016/07/22 00:56:11 Done.
+ const GURL&,
+ Profile*)>;
void RecordSinglePermissionAction(const content::MediaStreamRequest& request,
content::PermissionType permission_type,
Profile* profile,
PermissionActionCallback callback) {
if (ContentTypeIsRequested(permission_type, request)) {
- callback.Run(permission_type, request.security_origin, profile);
+ // TODO(stefanocs): Pass the actual |user_gesture| once this file has been
+ // refactored into PermissionContext.
+ callback.Run(permission_type, false /* user_gesture */,
+ request.security_origin, profile);
}
}

Powered by Google App Engine
This is Rietveld 408576698