chrome/browser/permissions/permission_uma_util.h - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: Remove push messaging add comment fix nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/media_stream_devices_controller.cc ('K') | « chrome/browser/permissions/permission_queue_controller.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.h

diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h

index 99ab839dfbd3041689987311a9109b4362d9c6e8..280c02c1783efc94c33177575d722963cb593d55 100644

--- a/chrome/browser/permissions/permission_uma_util.h

+++ b/chrome/browser/permissions/permission_uma_util.h

@@ -63,15 +63,19 @@ class PermissionUmaUtil {

const GURL& embedding_origin,

Profile* profile);

static void PermissionGranted(content::PermissionType permission,

+ bool user_gesture,

const GURL& requesting_origin,

Profile* profile);

static void PermissionDenied(content::PermissionType permission,

+ bool user_gesture,

const GURL& requesting_origin,

Profile* profile);

static void PermissionDismissed(content::PermissionType permission,

+ bool user_gesture,

const GURL& requesting_origin,

Profile* profile);

static void PermissionIgnored(content::PermissionType permission,

+ bool user_gesture,

const GURL& requesting_origin,

Profile* profile);

static void PermissionRevoked(content::PermissionType permission,

@@ -111,6 +115,7 @@ class PermissionUmaUtil {

static void RecordPermissionAction(content::PermissionType permission,

PermissionAction action,

PermissionSourceUI source_ui,

+ bool user_gesture,

const GURL& requesting_origin,

Profile* profile);