Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: Remove push messaging add comment fix nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index 832105d72951ec03dbb0ce4b9122b67be4b982d2..c6a95337c201f069d0b32f6989878eea1b32f5a4 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -17,11 +17,13 @@
PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(
const GURL& request_origin,
content::PermissionType permission_type,
+ bool user_gesture,
Profile* profile,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback)
: request_origin_(request_origin),
permission_type_(permission_type),
+ user_gesture_(user_gesture),
profile_(profile),
permission_decided_callback_(permission_decided_callback),
delete_callback_(delete_callback),
@@ -30,9 +32,10 @@ PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(
PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
DCHECK(is_finished_);
- if (!action_taken_)
- PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,
- profile_);
+ if (!action_taken_) {
+ PermissionUmaUtil::PermissionIgnored(permission_type_, user_gesture_,
+ request_origin_, profile_);
+ }
}
gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {

Powered by Google App Engine
This is Rietveld 408576698