chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/push_messaging/push_messaging_permission_context.cc ('K') | « chrome/browser/push_messaging/push_messaging_permission_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

index f063f638257513a4e69fc23f6b26508e742c0a7b..e274b1c6a8be6b6737adf627393d9e32f2aaf18f 100644

--- a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

+++ b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

@@ -164,7 +164,7 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {

BrowserPermissionCallback callback = base::Bind(DoNothing);

context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),

- callback,

+ true /* user_gesture */, callback,

blink::mojom::PermissionStatus::DENIED);

EXPECT_FALSE(context.was_persisted());

EXPECT_FALSE(context.was_granted());

@@ -172,7 +172,7 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {

SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,

CONTENT_SETTING_ALLOW);

context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),

- callback,

+ true /* user_gesture */, callback,

blink::mojom::PermissionStatus::GRANTED);

EXPECT_TRUE(context.was_persisted());

EXPECT_TRUE(context.was_granted());

@@ -180,7 +180,7 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {

SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,

CONTENT_SETTING_BLOCK);

context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),

- callback,

+ true /* user_gesture */, callback,

blink::mojom::PermissionStatus::GRANTED);

EXPECT_TRUE(context.was_persisted());

EXPECT_FALSE(context.was_granted());

@@ -188,7 +188,7 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {

SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,

CONTENT_SETTING_ASK);

context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),

- callback,

+ true /* user_gesture */, callback,

blink::mojom::PermissionStatus::GRANTED);

EXPECT_TRUE(context.was_persisted());

EXPECT_TRUE(context.was_granted());