Add gesture type value from desktop prompt to permission report

chrome/browser/permissions/permission_context_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_context_base.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 160 matching lines @@
 
 #if !defined(OS_ANDROID)
   PermissionRequestManager* permission_request_manager =
       PermissionRequestManager::FromWebContents(web_contents);
   // TODO(felt): sometimes |permission_request_manager| is null. This check is
   // meant to prevent crashes. See crbug.com/457091.
   if (!permission_request_manager)
     return;
   std::unique_ptr<PermissionBubbleRequest> request_ptr(
       new PermissionBubbleRequestImpl(
-          requesting_origin, permission_type_, profile_,
+          requesting_origin, permission_type_, user_gesture, profile_,
           base::Bind(&PermissionContextBase::PermissionDecided,
                      weak_factory_.GetWeakPtr(), id, requesting_origin,
-                     embedding_origin, callback),
+                     embedding_origin, user_gesture, callback),
           base::Bind(&PermissionContextBase::CleanUpBubble,
                      weak_factory_.GetWeakPtr(), id)));
   PermissionBubbleRequest* request = request_ptr.get();
 
   bool inserted =
       pending_bubbles_.add(id.ToString(), std::move(request_ptr)).second;
   DCHECK(inserted) << "Duplicate id " << id.ToString();
   permission_request_manager->AddRequest(request);
 #else
+  // TODO(stefanocs): Get user gesture from infobar.

[raymes, 2016/07/18 00:58:43]

Hmm, what does this mean?

[stefanocs, 2016/07/18 04:28:44]

I edited the comment, does it make sense for you or is it even needed?

[raymes, 2016/07/18 07:31:58]

Looks good, thanks!

   GetQueueController()->CreateInfoBarRequest(
       id, requesting_origin, embedding_origin,
       base::Bind(&PermissionContextBase::PermissionDecided,
                  weak_factory_.GetWeakPtr(), id, requesting_origin,
-                 embedding_origin, callback,
+                 embedding_origin, user_gesture, callback,
                  // the queue controller takes care of persisting the
                  // permission
                  false));
 #endif
 }
 
 void PermissionContextBase::PermissionDecided(
     const PermissionRequestID& id,
     const GURL& requesting_origin,
     const GURL& embedding_origin,
+    bool user_gesture,
     const BrowserPermissionCallback& callback,
     bool persist,
     ContentSetting content_setting) {
 #if !defined(OS_ANDROID)
   // Infobar persistence and its related UMA is tracked on the infobar
   // controller directly.
   if (persist) {
     DCHECK(content_setting == CONTENT_SETTING_ALLOW ||
            content_setting == CONTENT_SETTING_BLOCK);
     if (content_setting == CONTENT_SETTING_ALLOW)

[raymes, 2016/07/18 00:58:43]

nit: add {}

[stefanocs, 2016/07/18 04:28:45]

Done.

-      PermissionUmaUtil::PermissionGranted(permission_type_, requesting_origin,
-                                           profile_);
+      PermissionUmaUtil::PermissionGranted(permission_type_, user_gesture,
+                                           requesting_origin, profile_);
     else

[raymes, 2016/07/18 00:58:43]

nit: add {}

[stefanocs, 2016/07/18 04:28:44]

Done.

-      PermissionUmaUtil::PermissionDenied(permission_type_, requesting_origin,
-                                          profile_);
+      PermissionUmaUtil::PermissionDenied(permission_type_, user_gesture,
+                                          requesting_origin, profile_);
   } else {
     DCHECK_EQ(content_setting, CONTENT_SETTING_DEFAULT);
-    PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_origin,
-                                           profile_);
+    PermissionUmaUtil::PermissionDismissed(permission_type_, user_gesture,
+                                           requesting_origin, profile_);
   }
 #endif
 
   NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
                       persist, content_setting);
 }
 
 #if defined(OS_ANDROID)
 PermissionQueueController* PermissionContextBase::GetQueueController() {
   return permission_queue_controller_.get();
@@ skipping 49 matching lines @@
                                       content_setting);
 }
 
 bool PermissionContextBase::IsPermissionKillSwitchOn() const {
   const std::string param = variations::GetVariationParamValue(
       kPermissionsKillSwitchFieldStudy,
       PermissionUtil::GetPermissionString(permission_type_));
 
   return param == kPermissionsKillSwitchBlockedValue;
 }