Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 215313003: Remove applyAuthorStyles flag from ShadowRoot. (Closed)

Created:
6 years, 9 months ago by dglazkov
Modified:
6 years, 9 months ago
Reviewers:
esprehn, hayato, tasak
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cat is dead, use /deep/ instead. #

Patch Set 3 : Git is hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -673 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
D LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html View 1 chunk +0 lines, -243 lines 0 comments Download
D LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested.html View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule.html View 3 chunks +0 lines, -33 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule-expected.txt View 2 chunks +0 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-wrapper-reclaimed.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-nodes.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html View 1 chunk +0 lines, -151 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles.html View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-keyframes.html View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/tests/data/touch-action-tests.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/data/touch-action-tests.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
dglazkov
PTAL.
6 years, 9 months ago (2014-03-27 20:27:20 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-27 20:31:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215313003/1
6 years, 9 months ago (2014-03-27 20:31:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 20:55:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-27 20:55:18 UTC) #5
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-27 21:32:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215313003/20001
6 years, 9 months ago (2014-03-27 21:32:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:53 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:54 UTC) #9
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-27 22:35:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215313003/20001
6 years, 9 months ago (2014-03-27 22:37:27 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:49:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 22:49:07 UTC) #13
hayato
lgtm. Thank you for joining the party. Try bots are still complaining. Looks we have ...
6 years, 9 months ago (2014-03-28 03:59:30 UTC) #14
dglazkov
working on it! :)
6 years, 9 months ago (2014-03-28 04:07:01 UTC) #15
dglazkov
working on it! :)
6 years, 9 months ago (2014-03-28 04:07:02 UTC) #16
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-28 04:16:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/215313003/40001
6 years, 9 months ago (2014-03-28 04:16:34 UTC) #18
commit-bot: I haz the power
Change committed as 170271
6 years, 9 months ago (2014-03-28 05:27:07 UTC) #19
tkent
A revert of this CL has been created in https://codereview.chromium.org/216543002/ by tkent@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-28 07:08:03 UTC) #20
dglazkov
On 2014/03/28 07:08:03, tkent wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-03-28 17:02:56 UTC) #21
dglazkov
6 years, 9 months ago (2014-03-28 17:04:21 UTC) #22
Message was sent while issue was closed.
On 2014/03/28 17:02:56, dglazkov wrote:
> On 2014/03/28 07:08:03, tkent wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/216543002/ by mailto:tkent@chromium.org.
> > 
> > The reason for reverting is:
> >
>
w3c/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-004.html
> > started to fail.
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
> > .
> 
> I don't understand... this test is skipped. How did it still turn the tree
red?

Ohh. That's because I am an idiot. I unskipped it in the patch! :) Now
everything makes sense!

Powered by Google App Engine
This is Rietveld 408576698