Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: content/public/common/assert_matching_enums.cc

Issue 215313002: Comment enum matching assert to allow changes in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/assert_matching_enums.cc
diff --git a/content/public/common/assert_matching_enums.cc b/content/public/common/assert_matching_enums.cc
index 88a1b4a8166fc8247ec8b81875c6632d8100d2cf..92c7ed51fc5d3da909fa3f7ba0c240e92d97e2c2 100644
--- a/content/public/common/assert_matching_enums.cc
+++ b/content/public/common/assert_matching_enums.cc
@@ -14,13 +14,14 @@ namespace content {
#define COMPILE_ASSERT_MATCHING_ENUM(expected, actual) \
COMPILE_ASSERT(int(expected) == int(actual), mismatching_enums)
-COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationPortraitPrimary,
- PORTRAIT_PRIMARY);
-COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationLandscapePrimary,
- LANDSCAPE_PRIMARY);
-COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationPortraitSecondary,
- PORTRAIT_SECONDARY);
-COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationLandscapeSecondary,
- LANDSCAPE_SECONDARY);
+// TODO(mlamouri): this is temporary to allow to change the enum in Blink.
+// COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationPortraitPrimary,
+// PORTRAIT_PRIMARY);
+// COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationLandscapePrimary,
+// LANDSCAPE_PRIMARY);
+// COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationPortraitSecondary,
+// PORTRAIT_SECONDARY);
+// COMPILE_ASSERT_MATCHING_ENUM(blink::WebScreenOrientationLandscapeSecondary,
+// LANDSCAPE_SECONDARY);
} // namespace content
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698