chrome/browser/resources/settings/settings_resources.grd - Issue 2153113003: Settings Router Refactor: Migrate canonical route list to new-style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_resources.grd

Issue 2153113003: Settings Router Refactor: Migrate canonical route list to new-style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_router.js ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_resources.grd

diff --git a/chrome/browser/resources/settings/settings_resources.grd b/chrome/browser/resources/settings/settings_resources.grd

index 12f375f4849a4281e72515c4df7fbd8b5343b071..d63ef44da827dd907ff936a83bf16d83e943198b 100644

--- a/chrome/browser/resources/settings/settings_resources.grd

+++ b/chrome/browser/resources/settings/settings_resources.grd

@@ -633,7 +633,7 @@

<structure name="IDR_SETTINGS_PRINTING_PAGE_HTML"

file="printing_page/printing_page.html"

flattenhtml="true"

- allowexternalscript="true"

+ allowexternalscript="true"

type="chrome_html" />

<structure name="IDR_SETTINGS_PRINTING_PAGE_JS"

file="printing_page/printing_page.js"

@@ -681,7 +681,8 @@

type="chrome_html" />

<structure name="IDR_SETTINGS_ROUTE_JS"

file="route.js"

- type="chrome_html" />

+ type="chrome_html"

+ preprocess="true" />

<structure name="IDR_SETTINGS_CR_SETTINGS_ROUTER_HTML"

file="settings_page/settings_router.html"

type="chrome_html" />