url/url.gyp - Issue 2153093002: gyp: url_mojom should be a hard_dependency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url.gyp

Issue 2153093002: gyp: url_mojom should be a hard_dependency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/url.gyp

diff --git a/url/url.gyp b/url/url.gyp

index 4b7a4a0ee68138cca0b407a596b79db24f69d11a..1a6a605bd0e5681f18cea2370381183f112853a2 100644

--- a/url/url.gyp

+++ b/url/url.gyp

@@ -140,6 +140,10 @@

'export_dependent_settings': [

'../mojo/mojo_public.gyp:mojo_cpp_bindings',

+ # url_interfaces_mojom generates headers and is a hard dependency.

+ # It seems that this hard dependency status is not propagated to

brettw 2016/07/15 17:03:40 Just remove "it seems" because GYP does indeed not

Mostyn Bramley-Moore 2016/07/15 17:29:43 Done.

+ # this target, so we must set it explicitly.

+ 'hard_dependency': 1,

'dependencies': [

'../mojo/mojo_public.gyp:mojo_cpp_bindings',

'url_interfaces_mojom',

« no previous file with comments | « no previous file | no next file » | no next file with comments »