xvfb: improve robustness when stale lock files exist

xvfb: improve robustness when stale lock files exist

BUG=628517
Committed: https://chromium.googlesource.com/chromium/tools/build/+/bcbdb8067fd1521a67b788fda545bb0c2aed01a5

[Paweł Hajdan Jr., 2016-07-15 09:21:57]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Paweł Hajdan Jr., 2016-07-15 09:22:01]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 09:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 09:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 09:26:38]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-07-15 09:38:13]

Lgtm w/ nits

https://codereview.chromium.org/2153083002/diff/1/scripts/slave/xvfb.py
File scripts/slave/xvfb.py (right):

https://codereview.chromium.org/2153083002/diff/1/scripts/slave/xvfb.py#newco...
scripts/slave/xvfb.py:69: print 'Trying to remove xvfb lock file failed: %s' % e
nit: Removing xvfb lock file failed
IMHO "Trying to" is not necessary

Also any reason not to use logging.exception?

[Paweł Hajdan Jr., 2016-07-15 09:40:40]

https://codereview.chromium.org/2153083002/diff/1/scripts/slave/xvfb.py
File scripts/slave/xvfb.py (right):

https://codereview.chromium.org/2153083002/diff/1/scripts/slave/xvfb.py#newco...
scripts/slave/xvfb.py:69: print 'Trying to remove xvfb lock file failed: %s' % e
On 2016/07/15 at 09:38:13, Sergiy Byelozyorov wrote:
> nit: Removing xvfb lock file failed
> IMHO "Trying to" is not necessary

Done

> Also any reason not to use logging.exception?

Consistency with rest of the file

[Paweł Hajdan Jr., 2016-07-15 09:40:44]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-07-15 09:40:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/2153083002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-07-15 09:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 09:45:04]

Description was changed from

==========
xvfb: improve robustness when stale lock files exist

BUG=628517
==========

to

==========
xvfb: improve robustness when stale lock files exist

BUG=628517

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/bcbdb8067fd1521a67b7...
==========

[commit-bot: I haz the power, 2016-07-15 09:45:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/bcbdb8067fd1521a67b7...