Should not call FocusController::setFocusedFrame() for detached frame

third_party/WebKit/Source/core/page/FocusController.cpp

Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index c7d11a226f30bdcff86214c2462d43f70a5ee4cc..637feb60f85e10e6ef1ef4b8a05bd1a7e77f4431 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -772,7 +772,8 @@ void FocusController::focusDocumentView(Frame* frame, bool notifyEmbedder)
             dispatchFocusEvent(*document, *focusedElement);
     }
 
-    setFocusedFrame(frame, notifyEmbedder);
+    if (newFocusedFrame && newFocusedFrame->selection().isAvailable())
+        setFocusedFrame(frame, notifyEmbedder);

[yosin_UTC9, 2016/07/19 01:44:46]

I think we should check |LocalFrame::selection().isAvailable())| in
|FocusController::setFocusedFrame()| rather than here.

|dispatchEvent(blur)| at L737 can destroy |newFrame|.

720 void FocusController::setFocusedFrame(Frame* frame, bool notifyEmbedder)
...
734    // Now that the frame is updated, fire events and update the selection
focused states of both frames.
735    if (oldFrame && oldFrame->view()) {
736        oldFrame->selection().setFocused(false);
737       
oldFrame->domWindow()->dispatchEvent(Event::create(EventTypeNames::blur));
738    }
739
740    if (newFrame && newFrame->view() && isFocused()) {
741        newFrame->selection().setFocused(true);
742       
newFrame->domWindow()->dispatchEvent(Event::create(EventTypeNames::focus));
743    }

[kochi, 2016/07/20 08:05:27]

The original test case fails after dispatching events in this
function (line 764 and 772).

Let me try to fix the failing case first.

 }
 
 LocalFrame* FocusController::focusedFrame() const