third_party/WebKit/LayoutTests/fast/dom/Selection/selection-crash.html - Issue 2153063003: Should not call FocusController::setFocusedFrame() for detached frame

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/Selection/selection-crash.html

Issue 2153063003: Should not call FocusController::setFocusedFrame() for detached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for comment #20 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <button id="button"></button>

	5 <iframe id="iframe"></iframe>

	6 <script>

	7 // This is a reproduction case for crbug.com/626750.

	8 async_test((test) => {

	9 button.addEventListener('focus', () => {

	10 iframe.contentWindow.focus();

	11 });

	12

	13 button.addEventListener('blur', test.step_func_done(() => {

	14 // This detaches <iframe>.

	15 document.open();

	16 assert_true(true, "Test did not crash.");

	17 }));

	18

	19 window.addEventListener('load', () => button.focus());

	20 }, 'focusing on detached frame should not crash');

	21 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | third_party/WebKit/Source/core/page/FocusController.cpp » ('J')