third_party/WebKit/LayoutTests/fast/dom/Selection/selection-crash.html - Issue 2153063003: Should not call FocusController::setFocusedFrame() for detached frame

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/Selection/selection-crash.html

Issue 2153063003: Should not call FocusController::setFocusedFrame() for detached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <button autofocus onfocus="focused()" onfocusout="focusedout()"></button>

	5 <iframe id="iframe"></iframe>

	6 <script>

	7 // This is a reproduction case for crbug.com/626750.

	8 function focusedout() {

	9 document.open();

	10 test(() => {}, "test did not crash.");
	yosin_UTC9 2016/07/19 01:44:46 We should have an assertion to check focused eleme We should have an assertion to check focused element. I'm not sure when "focus" event dispatch, before/after "load"? I think it is better to use \|async_test()\| to dispatch "focus" event explicitly rather than depending on "autofocus". kochi 2016/07/20 08:05:27 What is the intention? This focus/blur(focusout) Show quoted text On 2016/07/19 01:44:46, Yosi_UTC9 wrote: > We should have an assertion to check focused element. What is the intention? This focus/blur(focusout) evnet handler will be called during the focus change, not after the all focus changes, including ones caused by event handlers. This test intentionally change focus during focus handler, so testing the result makes little sense here. Show quoted text > I'm not sure when "focus" event dispatch, before/after "load"? > I think it is better to use \|async_test()\| to dispatch "focus" event explicitly > rather than depending on "autofocus". Changed not to depend on autofocus. Initially I used autofocus because the original reproduction case used, but button.focus() should work as well.
	11 }

	12 function focused() {

	13 iframe.contentWindow.focus();

	14 }

	15 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | third_party/WebKit/Source/core/page/FocusController.cpp » ('J')